Bug 168613 - Simple line layout: Implement absoluteQuadsForRange.
Summary: Simple line layout: Implement absoluteQuadsForRange.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 205527
  Show dependency tree / graph
 
Reported: 2017-02-20 14:39 PST by zalan
Modified: 2019-12-23 09:10 PST (History)
10 users (show)

See Also:

Attachments
Patch (8.34 KB, patch)
2017-02-20 14:54 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (20.79 KB, patch)
2017-02-20 16:35 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-02-20 14:39:28 PST 
This is used by Range::getClientRects.
Comment 1 Radar WebKit Bug Importer 2017-02-20 14:40:12 PST 
<rdar://problem/30614618>
Comment 2 zalan 2017-02-20 14:54:58 PST 
Created attachment 302174 [details]
Patch
Comment 3 zalan 2017-02-20 16:35:18 PST 
Created attachment 302201 [details]
Patch
Comment 4 WebKit Commit Bot 2017-02-20 17:22:48 PST 
The commit-queue encountered the following flaky tests while processing attachment 302201 [details]:

The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-02-20 17:23:27 PST 
The commit-queue encountered the following flaky tests while processing attachment 302201 [details]:

http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, mitz@webkit.org, rniwa@webkit.org, and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2017-02-20 18:13:49 PST 
Comment on attachment 302201 [details]
Patch

Clearing flags on attachment: 302201

Committed r212693: <http://trac.webkit.org/changeset/212693>
Comment 7 WebKit Commit Bot 2017-02-20 18:13:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Daniel Bates 2019-12-23 09:09:51 PST 
Simple line layout does not seem to handle empty rects at run boundary points the same way as line box layout. As a result, getClientRects() and getBoundingClientRect() give differing results depending on which line layout we are using. See bug #205527.