Use the new drag code path when dragging links
Created attachment 302169 [details] Patch
Created attachment 302171 [details] Patch
Attachment 302171 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/PasteboardWriter.mm:69: Extra space in capture list. [whitespace/brackets] [4] ERROR: Source/WebCore/platform/mac/PasteboardWriter.mm:71: Extra space in capture list. [whitespace/brackets] [4] ERROR: Source/WebCore/platform/mac/PasteboardWriter.mm:73: Extra space in capture list. [whitespace/brackets] [4] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 302171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302171&action=review > Source/WebCore/platform/PasteboardWriterData.cpp:57 > +void PasteboardWriterData::setURL(URL url) Could we make this a const URL& or URL&&? > Source/WebCore/platform/mac/PasteboardWriter.mm:69 > + [pasteboardItem setPropertyList:@[ cocoaURL.relativeString, baseCocoaURL.absoluteString ] forType:toUTI(NSURLPboardType).get()]; Is there any case where baseCocoaURL.absoluteString can return nil even though baseCocoaURL exists? (same with cocoaURL.relativeString)
Comment on attachment 302171 [details] Patch Attachment 302171 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3161328 New failing tests: fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html fast/events/drag-parent-node.html editing/pasteboard/drop-text-without-selection.html fast/events/drag-select-when-zoomed-with-header.html fast/events/drag-and-drop-link-into-focused-contenteditable.html fast/events/drag-and-drop-link.html fast/events/dropzone-003.html fast/events/content-changed-during-drop.html fast/events/drag-in-frames.html editing/pasteboard/files-during-page-drags.html editing/pasteboard/drop-link.html
Created attachment 302175 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302171 [details] Patch Attachment 302171 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3161401 New failing tests: fast/events/shift-drag-selection-on-link-triggers-drag-n-drop.html fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html fast/events/drag-parent-node.html editing/pasteboard/drop-text-without-selection.html fast/events/drag-in-frames.html fast/events/drag-and-drop-link-into-focused-contenteditable.html editing/pasteboard/files-during-page-drags.html fast/events/dropzone-003.html fast/css/user-drag-none.html fast/events/content-changed-during-drop.html fast/events/drag-and-drop-link.html editing/pasteboard/drop-link.html
Created attachment 302182 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 302184 [details] Patch
Attachment 302184 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:222: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WebCore/platform/mac/PasteboardWriter.mm:70: Extra space in capture list. [whitespace/brackets] [4] ERROR: Source/WebCore/platform/mac/PasteboardWriter.mm:72: Extra space in capture list. [whitespace/brackets] [4] ERROR: Source/WebCore/platform/mac/PasteboardWriter.mm:74: Extra space in capture list. [whitespace/brackets] [4] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r212681: <http://trac.webkit.org/changeset/212681>
It looks like this change caused editing/pasteboard/drop-text-events.html and fast/events/dropzone-003.html to fail on WK1: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r212713%20(3843)/results.html