RESOLVED FIXED Bug 168606
Remove ENABLE_THREADED_COMPOSITOR build option 
https://bugs.webkit.org/show_bug.cgi?id=168606
Summary Remove ENABLE_THREADED_COMPOSITOR build option
Carlos Garcia Campos
Reported 2017-02-20 10:01:51 PST
Now that we have AC mode on demand with the threaded compositor there's no reason to keep the old AC code.
Attachments
Patch (31.86 KB, patch)
2017-02-20 10:05 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (31.67 KB, patch)
2017-02-20 10:28 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-02-20 10:05:20 PST
Created attachment 302154 [details] Patch
Carlos Garcia Campos
Comment 2 2017-02-20 10:28:38 PST
Created attachment 302155 [details] Patch
Michael Catanzaro
Comment 3 2017-02-20 10:32:35 PST
Comment on attachment 302155 [details] Patch Can we remove USE(TEXTURE_MAPPER_GL)?
Michael Catanzaro
Comment 4 2017-02-20 15:06:38 PST
Note: * There are no advantages to disabling threaded compositor. * There are two big disadvantages: * We never use it or test it. * It regularly causes full desktop lockups, bug #126122. Hence removing it should be uncontroversial.
Carlos Garcia Campos
Comment 5 2017-02-20 22:40:26 PST
(In reply to comment #3) > Comment on attachment 302155 [details] > Patch > > Can we remove USE(TEXTURE_MAPPER_GL)? Of course not.
Carlos Garcia Campos
Comment 6 2017-02-20 23:14:11 PST
Committed r212703: <http://trac.webkit.org/changeset/212703>
Michael Catanzaro
Comment 7 2017-02-21 07:49:07 PST
(In reply to comment #5) > (In reply to comment #3) > > Comment on attachment 302155 [details] > > Patch > > > > Can we remove USE(TEXTURE_MAPPER_GL)? > > Of course not. It's a shame that there's no documentation for what all these different graphics modes are. ;)
Don Olmstead
Comment 8 2017-02-21 16:55:37 PST
Carlos this ended up breaking WinCairo. See https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/65682/steps/compile-webkit/logs/stdio for linker errors for TextureMapperTiledBackingStore.
Carlos Garcia Campos
Comment 9 2017-02-21 23:55:05 PST
(In reply to comment #8) > Carlos this ended up breaking WinCairo. See > https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/65682/ > steps/compile-webkit/logs/stdio for linker errors for > TextureMapperTiledBackingStore. I'm sorry, I confused TextureMapperBackingStore.cpp with TextureMapperTiledBackingStore.cpp. I'll fix it now.
Carlos Garcia Campos
Comment 10 2017-02-21 23:56:53 PST
(In reply to comment #9) > (In reply to comment #8) > > Carlos this ended up breaking WinCairo. See > > https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/65682/ > > steps/compile-webkit/logs/stdio for linker errors for > > TextureMapperTiledBackingStore. > > I'm sorry, I confused TextureMapperBackingStore.cpp with > TextureMapperTiledBackingStore.cpp. I'll fix it now. Hopefully fixed in http://trac.webkit.org/changeset/212811
Don Olmstead
Comment 11 2017-02-22 11:23:58 PST
Back to green! Thanks you
Note You need to log in before you can comment on or make changes to this bug.