WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
168604
[GTK] Do something with processDidBecomeUnresponsive
https://bugs.webkit.org/show_bug.cgi?id=168604
Summary
[GTK] Do something with processDidBecomeUnresponsive
Michael Catanzaro
Reported
2017-02-20 09:14:52 PST
We have an issue in Epiphany where attempting to Stop or close an unresponsive web process takes a very long time (I think 30 seconds). It would be useful for us to have a way to detect this and kill the process immediately. I do think this should really be handled by WebKit, not the application, though: if the web process doesn't respond to Stop or close within a second or two, something's gone wrong and it surely needs to be killed. The WebKit::NavigationClient and WebKit::LoaderClient classes expose processDidBecomeUnresponsive/processDidBecomeResponsive alongside processDidCrash. I don't know what the difference between the two clients is, but we implement WebKit::LoaderClient in WebKitLoaderClient.cpp. We should probably handle unresponsive notifications there, e.g. by manually killing the web process and then calling webkitWebViewWebProcessCrashed.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2017-02-20 15:08:43 PST
I think Evolution has had problems with this as well, though I've never noticed had any problems with it myself.
Michael Catanzaro
Comment 2
2017-02-20 15:09:41 PST
(In reply to
comment #0
)
> We > should probably handle unresponsive notifications there, e.g. by manually > killing the web process and then calling webkitWebViewWebProcessCrashed.
Or just expose a new signal for unresponsive process.
Milan Crha
Comment 3
2017-02-21 01:40:05 PST
It's not always stuck, it can sometimes do something with a large page in the main thread, which makes the WebProcess "unresponsive". Like the recent hyphenation issue. The 30 seconds can be about D-Bus timeouts, it is as such in the evolution side at least, when talking to its web extension.
Michael Catanzaro
Comment 4
2017-03-13 12:13:07 PDT
Separately, we ought to handle processes that exceed reasonable CPU usage. See
bug #169456
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug