Bug 16860 - a bit of cleanup after the Activation optimization
Summary: a bit of cleanup after the Activation optimization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-13 09:17 PST by Darin Adler
Modified: 2008-01-26 10:58 PST (History)
0 users

See Also:

Attachments
patch (28.27 KB, patch)
2008-01-13 09:34 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
patch (revised with a tiny change to pass all tests) (28.30 KB, patch)
2008-01-13 11:18 PST, Darin Adler 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-01-13 09:17:40 PST 
Here's a bit of clean-up fro the just-landed Activation optimization.
Comment 1 Darin Adler 2008-01-13 09:34:01 PST 
Created attachment 18422 [details]
patch
Comment 2 Darin Adler 2008-01-13 11:18:41 PST 
Created attachment 18424 [details]
patch (revised with a tiny change to pass all tests)
Comment 3 Eric Seidel (no email) 2008-01-25 13:09:24 PST 
Comment on attachment 18424 [details]
patch (revised with a tiny change to pass all tests)

LGTM
Comment 4 Darin Adler 2008-01-25 13:10:35 PST 
Comment on attachment 18424 [details]
patch (revised with a tiny change to pass all tests)

I think this patch no longer cleanly applies because of the new activation stack. I'll find out when I get some time.
Comment 5 Darin Adler 2008-01-26 10:58:31 PST 
Committed revision 29810.