Bug 168595 – Add 'webglcontextchanged' WebGLContextEvent

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Dean Jackson]

Add 'webglcontextchanged' WebGLContextEvent

[Radar WebKit Bug Importer]

<rdar://problem/30604254>

[Dean Jackson]

Created attachment 302145 [details]
Patch

[Antoine Quint]

Comment on attachment 302145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302145&action=review

> Source/WebCore/platform/graphics/GraphicsContext3D.h:1434
> +    // FIXME: Layering violation.

Would be nicer with a bug link to go with it.

> LayoutTests/fast/canvas/webgl/webglcontextchangedevent.html:1
> +<script>

You could use the JS test helpers here (js-test-pre.js and js-test-post.js) which would remove some boilerplate here and the custom log function.

> LayoutTests/fast/canvas/webgl/webglcontextchangedevent.html:25
> +    let handleChangedEvent = (event) => {

Weird to use a `let` here vs. a `const`. You could/should also just declare a function just like you are above for `log`.

> LayoutTests/fast/canvas/webgl/webglcontextchangedevent.html:35
> +        let gl = c.getContext("webgl");

Use `const`.

> LayoutTests/fast/canvas/webgl/webglcontextchangedevent.html:40
> +    let gl = document.querySelector("canvas").getContext("webgl");

Use `const`.

[Dean Jackson]

Committed r212637: <http://trac.webkit.org/changeset/212637>

[Ryan Haddad]

Reverted r212637 for reason:

This change broke iOS builds.

Committed r212639: <http://trac.webkit.org/changeset/212639>

[Ryan Haddad]

(In reply to comment #5)
> Reverted r212637 for reason:
> 
> This change broke iOS builds.
> 
> Committed r212639: <http://trac.webkit.org/changeset/212639>

Link to failure:
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20%28Build%29/builds/4292

[Jon Lee]

Reverted r212639 for reason:

Have a fix for the linker error on iOS.

Committed r212650: <http://trac.webkit.org/changeset/212650>

[Jon Lee]

Fix for iOS build:
Committed r212651: <http://trac.webkit.org/changeset/212651>

[Kirill S. Dmitrenko]

Am I right to say that `webglcontextchanged` works as initially proposed: as an API user I'll have to re-query context limits and capabilities and, if some's changed, recreate some resources? Or, if limits and capabilities change'll cause some of my application's resources to invalidate, `webglcontextlost`'ll be generated?