Bug 168575 - Web Inspector: RTL: adjust positioning of scope bar items with multiple values
Summary: Web Inspector: RTL: adjust positioning of scope bar items with multiple values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
: 168286 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-19 08:26 PST by BJ Burg
Modified: 2017-02-20 11:16 PST (History)
4 users (show)

See Also:

Attachments
scope bar - LTR (39.44 KB, image/png)
2017-02-19 13:53 PST, BJ Burg 		no flags Details
scope bar - RTL (35.23 KB, image/png)
2017-02-19 13:53 PST, BJ Burg 		no flags Details
Patch (2.28 KB, patch)
2017-02-19 13:56 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-02-19 08:26:31 PST 
Steps to reproduce:

1. Open Resources Tab
=> Multiple select for Resource Type should have arrows on the trailing edge to hint about multiple options.
=> Clicking on the multiple select should pop up a select menu at approximately where the scope bar item is.
Comment 1 BJ Burg 2017-02-19 13:53:24 PST 
Created attachment 302085 [details]
scope bar - LTR
Comment 2 BJ Burg 2017-02-19 13:53:41 PST 
Created attachment 302086 [details]
scope bar - RTL
Comment 3 BJ Burg 2017-02-19 13:56:29 PST 
Created attachment 302087 [details]
Patch
Comment 4 BJ Burg 2017-02-19 14:56:14 PST 
*** Bug 168286 has been marked as a duplicate of this bug. ***
Comment 5 BJ Burg 2017-02-19 14:56:57 PST 
<rdar://problem/30508109>
Comment 6 Matt Baker 2017-02-20 10:50:36 PST 
Comment on attachment 302087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302087&action=review

> Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:60
> +body[dir=ltr] .scope-bar > li.multiple > select {

I had to compare the new and old <select> popovers in Photoshop to tell the difference. Nice touch. It looks like we could get a few pixels closer still (on retina at least) but I don't think it matters.
Comment 7 Matt Baker 2017-02-20 10:50:56 PST 
Comment on attachment 302087 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2017-02-20 11:16:36 PST 
Comment on attachment 302087 [details]
Patch

Clearing flags on attachment: 302087

Committed r212662: <http://trac.webkit.org/changeset/212662>
Comment 9 WebKit Commit Bot 2017-02-20 11:16:41 PST 
All reviewed patches have been landed.  Closing bug.