RESOLVED FIXED 168575
Web Inspector: RTL: adjust positioning of scope bar items with multiple values 
https://bugs.webkit.org/show_bug.cgi?id=168575
Summary Web Inspector: RTL: adjust positioning of scope bar items with multiple values
Blaze Burg
Reported 2017-02-19 08:26:31 PST
Steps to reproduce: 1. Open Resources Tab => Multiple select for Resource Type should have arrows on the trailing edge to hint about multiple options. => Clicking on the multiple select should pop up a select menu at approximately where the scope bar item is.
Attachments
scope bar - LTR (39.44 KB, image/png)
2017-02-19 13:53 PST, Blaze Burg 		no flags
Details
scope bar - RTL (35.23 KB, image/png)
2017-02-19 13:53 PST, Blaze Burg 		no flags
Details
Patch (2.28 KB, patch)
2017-02-19 13:56 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-02-19 13:53:24 PST
Created attachment 302085 [details] scope bar - LTR
Blaze Burg
Comment 2 2017-02-19 13:53:41 PST
Created attachment 302086 [details] scope bar - RTL
Blaze Burg
Comment 3 2017-02-19 13:56:29 PST
Created attachment 302087 [details] Patch
Blaze Burg
Comment 4 2017-02-19 14:56:14 PST
*** Bug 168286 has been marked as a duplicate of this bug. ***
Blaze Burg
Comment 5 2017-02-19 14:56:57 PST
<rdar://problem/30508109>
Matt Baker
Comment 6 2017-02-20 10:50:36 PST
Comment on attachment 302087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302087&action=review > Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:60 > +body[dir=ltr] .scope-bar > li.multiple > select { I had to compare the new and old <select> popovers in Photoshop to tell the difference. Nice touch. It looks like we could get a few pixels closer still (on retina at least) but I don't think it matters.
Matt Baker
Comment 7 2017-02-20 10:50:56 PST
Comment on attachment 302087 [details] Patch r=me
WebKit Commit Bot
Comment 8 2017-02-20 11:16:36 PST
Comment on attachment 302087 [details] Patch Clearing flags on attachment: 302087 Committed r212662: <http://trac.webkit.org/changeset/212662>
WebKit Commit Bot
Comment 9 2017-02-20 11:16:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.