Bug 168574 – functionTestWasmModuleFunctions() should use a MarkedArgumentBuffer for storing args instead of a Vector.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Vectors don't tell GC about the need to scan the args.

[JF Bastien]

I think we're better off getting rid of the function entirely, now that we have the JS builder.

[Mark Lam]

(In reply to comment #1)
> I think we're better off getting rid of the function entirely, now that we
> have the JS builder.

Is functionTestWasmModuleFunctions() no longer needed?

[JF Bastien]

(In reply to comment #2)
> (In reply to comment #1)
> > I think we're better off getting rid of the function entirely, now that we
> > have the JS builder.
> 
> Is functionTestWasmModuleFunctions() no longer needed?

IIRC we need to update some tests to use the JS builder instead of that function. It's still needed until we update the tests.

[Mark Lam]

Created attachment 302114 [details]
proposed patch.

[Mark Lam]

Thanks for the review.  Landed in r212620: <http://trac.webkit.org/r212620>.

[Keith Miller]

Yeah, I'm pretty sure we don't have tests that use this function anymore. Also, as a note, we don't really need to use a MarkedArgumentBuffer since we can't put JSCells into that vector so the GC won't see anything of interest anyway. The only reason the contents of that vector were JSValues is to avoid casting when we did vmEntryToJavaScript.