Bug 168574 - functionTestWasmModuleFunctions() should use a MarkedArgumentBuffer for storing args instead of a Vector.
Summary: functionTestWasmModuleFunctions() should use a MarkedArgumentBuffer for stori...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-19 08:17 PST by Mark Lam
Modified: 2017-02-20 09:27 PST (History)
6 users (show)

See Also:

Attachments
proposed patch. (3.35 KB, patch)
2017-02-19 19:53 PST, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-02-19 08:17:40 PST 
Vectors don't tell GC about the need to scan the args.
Comment 1 JF Bastien 2017-02-19 13:44:23 PST 
I think we're better off getting rid of the function entirely, now that we have the JS builder.
Comment 2 Mark Lam 2017-02-19 13:54:12 PST 
(In reply to comment #1)
> I think we're better off getting rid of the function entirely, now that we
> have the JS builder.

Is functionTestWasmModuleFunctions() no longer needed?
Comment 3 JF Bastien 2017-02-19 13:56:07 PST 
(In reply to comment #2)
> (In reply to comment #1)
> > I think we're better off getting rid of the function entirely, now that we
> > have the JS builder.
> 
> Is functionTestWasmModuleFunctions() no longer needed?

IIRC we need to update some tests to use the JS builder instead of that function. It's still needed until we update the tests.
Comment 4 Mark Lam 2017-02-19 19:53:45 PST 
Created attachment 302114 [details]
proposed patch.
Comment 5 Mark Lam 2017-02-19 20:02:18 PST 
Thanks for the review.  Landed in r212620: <http://trac.webkit.org/r212620>.
Comment 6 Keith Miller 2017-02-20 09:27:34 PST 
Yeah, I'm pretty sure we don't have tests that use this function anymore. Also, as a note, we don't really need to use a MarkedArgumentBuffer since we can't put JSCells into that vector so the GC won't see anything of interest anyway. The only reason the contents of that vector were JSValues is to avoid casting when we did vmEntryToJavaScript.