Bug 168571 - [SOUP] Call SoupNetworkSession::setShouldIgnoreTLSErrors when testRunner.setAllowsAnySSLCertificate() is called
Summary: [SOUP] Call SoupNetworkSession::setShouldIgnoreTLSErrors when testRunner.setA...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-02-19 03:05 PST by Carlos Garcia Campos
Modified: 2017-02-19 22:32 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2017-02-19 03:06 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-19 03:05:34 PST 
We only use that from web sockets. This would fix http/tests/ssl/upgrade-origin-usage.html
Comment 1 Carlos Garcia Campos 2017-02-19 03:06:55 PST 
Created attachment 302074 [details]
Patch
Comment 2 Michael Catanzaro 2017-02-19 09:24:57 PST 
Comment on attachment 302074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302074&action=review

> Source/WebCore/testing/InternalSettings.cpp:768
>      Settings::setAllowsAnySSLCertificate(allowsAnyCertificate);
> +#if USE(SOUP)
> +    SoupNetworkSession::setShouldIgnoreTLSErrors(allowsAnyCertificate);
> +#endif

Why is this the right place? Why not in Settings::setAllowsAnySSLCertificate?
Comment 3 Carlos Garcia Campos 2017-02-19 22:25:11 PST 
(In reply to comment #2)
> Comment on attachment 302074 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302074&action=review
> 
> > Source/WebCore/testing/InternalSettings.cpp:768
> >      Settings::setAllowsAnySSLCertificate(allowsAnyCertificate);
> > +#if USE(SOUP)
> > +    SoupNetworkSession::setShouldIgnoreTLSErrors(allowsAnyCertificate);
> > +#endif
> 
> Why is this the right place? Why not in Settings::setAllowsAnySSLCertificate?

I wanted to make sure that this is only used from layout tests.
Comment 4 Carlos Garcia Campos 2017-02-19 22:32:48 PST 
Committed r212623: <http://trac.webkit.org/changeset/212623>