RESOLVED FIXED168571
[SOUP] Call SoupNetworkSession::setShouldIgnoreTLSErrors when testRunner.setAllowsAnySSLCertificate() is called 
https://bugs.webkit.org/show_bug.cgi?id=168571
Summary [SOUP] Call SoupNetworkSession::setShouldIgnoreTLSErrors when testRunner.setA...
Carlos Garcia Campos
Reported 2017-02-19 03:05:34 PST
We only use that from web sockets. This would fix http/tests/ssl/upgrade-origin-usage.html
Attachments
Patch (1.56 KB, patch)
2017-02-19 03:06 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-02-19 03:06:55 PST
Created attachment 302074 [details] Patch
Michael Catanzaro
Comment 2 2017-02-19 09:24:57 PST
Comment on attachment 302074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302074&action=review > Source/WebCore/testing/InternalSettings.cpp:768 > Settings::setAllowsAnySSLCertificate(allowsAnyCertificate); > +#if USE(SOUP) > + SoupNetworkSession::setShouldIgnoreTLSErrors(allowsAnyCertificate); > +#endif Why is this the right place? Why not in Settings::setAllowsAnySSLCertificate?
Carlos Garcia Campos
Comment 3 2017-02-19 22:25:11 PST
(In reply to comment #2) > Comment on attachment 302074 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302074&action=review > > > Source/WebCore/testing/InternalSettings.cpp:768 > > Settings::setAllowsAnySSLCertificate(allowsAnyCertificate); > > +#if USE(SOUP) > > + SoupNetworkSession::setShouldIgnoreTLSErrors(allowsAnyCertificate); > > +#endif > > Why is this the right place? Why not in Settings::setAllowsAnySSLCertificate? I wanted to make sure that this is only used from layout tests.
Carlos Garcia Campos
Comment 4 2017-02-19 22:32:48 PST
Committed r212623: <http://trac.webkit.org/changeset/212623>
Note You need to log in before you can comment on or make changes to this bug.