Bug 168568 - [GTK] Some tests require a long timeout
Summary: [GTK] Some tests require a long timeout
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, LayoutTestFailure
Depends on:
Reported: 2017-02-19 00:03 PST by Carlos Garcia Campos
Modified: 2017-07-25 08:48 PDT (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-19 00:03:11 PST

Those tests are timing out because the need ~60 seconds to run, they are testing the default network timeout in XHR that is set to 60 seconds. That works in apple bots that use 30 seconds as the normal timeout and 150 for slow (30 * 5 ). In the GTK+ port we use 6 seconds for the normal timeout and 30 for slow (6 * 5). The obvious solution is to increase the timeouts, but that would make the whole test suite slower to run, and apparently there are only two tests affected by this. Both pass with a long enough timeout. Maybe we could make a way to mark tests as even slower, or even provide a way to set the minimum time required to run a particular test in the tests expectations or test_options.json. For now I'm going to mark those tests as timing out.
Comment 1 Charlie Turner 2017-07-25 08:48:24 PDT
Timeouts were raised in r218270 making both these tests pass consistently.