Bug 168543 – [SOUP] Add support for "nextHopProtocol" for Resource Timing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joseph Pecoraro]

[GTK] Add support for "nextHopProtocol" for Resource Timing

Spec:
https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-nexthopprotocol

Tests:
imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.html

Related:
Bug 168351

[Lauro Moura]

The WPT resync for service worker tests in r264043 added another test depending on nextHopProtocol: imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-protocol.https.html. Gardened it with the other two tests in r264057.

[Lauro Moura]

(In reply to Lauro Moura from comment #1)
> The WPT resync for service worker tests in r264043 added another test
> depending on nextHopProtocol:
> imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-
> protocol.https.html. Gardened it with the other two tests in r264057.

Ditto for imported/w3c/web-platform-tests/resource-timing/nextHopProtocol-tao-protected.https.html from r264458.

[Carlos Garcia Campos]

*** Bug 222558 has been marked as a duplicate of this bug. ***

[Carlos Garcia Campos]

Created attachment 425971 [details]
Patch

[Carlos Garcia Campos]

Created attachment 425972 [details]
Patch

[Michael Catanzaro]

Comment on attachment 425972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425972&action=review

Thank you!

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1005
> +    m_networkLoadMetrics.protocol = soup_message_get_http_version(m_soupMessage.get()) == SOUP_HTTP_1_0 ? "http/1.0" : "http/1.1";

Are libsoup3 and HTTP/2 covered elsewhere?

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #6)
> Comment on attachment 425972 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425972&action=review
> 
> Thank you!
> 
> > Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1005
> > +    m_networkLoadMetrics.protocol = soup_message_get_http_version(m_soupMessage.get()) == SOUP_HTTP_1_0 ? "http/1.0" : "http/1.1";
> 
> Are libsoup3 and HTTP/2 covered elsewhere?

Not yet.

[Carlos Garcia Campos]

Committed r276009 (236561@main): <https://commits.webkit.org/236561@main>

[Joseph Pecoraro]

Comment on attachment 425972 [details]
Patch

Nice!