Bug 168543 - [SOUP] Add support for "nextHopProtocol" for Resource Timing
Summary: [SOUP] Add support for "nextHopProtocol" for Resource Timing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on: 168351
Blocks:
  Show dependency treegraph
 
Reported: 2017-02-17 17:36 PST by Joseph Pecoraro
Modified: 2021-04-26 12:34 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.70 KB, patch)
2021-04-14 05:08 PDT, Carlos Garcia Campos
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2021-04-14 05:18 PDT, Carlos Garcia Campos
aperez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-02-17 17:36:41 PST
[GTK] Add support for "nextHopProtocol" for Resource Timing

Spec:
https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-nexthopprotocol

Tests:
imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.html

Related:
Bug 168351
Comment 1 Lauro Moura 2020-07-07 20:37:48 PDT
The WPT resync for service worker tests in r264043 added another test depending on nextHopProtocol: imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-protocol.https.html. Gardened it with the other two tests in r264057.
Comment 2 Lauro Moura 2020-07-16 20:57:56 PDT
(In reply to Lauro Moura from comment #1)
> The WPT resync for service worker tests in r264043 added another test
> depending on nextHopProtocol:
> imported/w3c/web-platform-tests/service-workers/service-worker/next-hop-
> protocol.https.html. Gardened it with the other two tests in r264057.

Ditto for imported/w3c/web-platform-tests/resource-timing/nextHopProtocol-tao-protected.https.html from r264458.
Comment 3 Carlos Garcia Campos 2021-04-14 05:05:22 PDT
*** Bug 222558 has been marked as a duplicate of this bug. ***
Comment 4 Carlos Garcia Campos 2021-04-14 05:08:57 PDT
Created attachment 425971 [details]
Patch
Comment 5 Carlos Garcia Campos 2021-04-14 05:18:38 PDT
Created attachment 425972 [details]
Patch
Comment 6 Michael Catanzaro 2021-04-14 08:51:30 PDT
Comment on attachment 425972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425972&action=review

Thank you!

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1005
> +    m_networkLoadMetrics.protocol = soup_message_get_http_version(m_soupMessage.get()) == SOUP_HTTP_1_0 ? "http/1.0" : "http/1.1";

Are libsoup3 and HTTP/2 covered elsewhere?
Comment 7 Carlos Garcia Campos 2021-04-15 01:08:23 PDT
(In reply to Michael Catanzaro from comment #6)
> Comment on attachment 425972 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425972&action=review
> 
> Thank you!
> 
> > Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1005
> > +    m_networkLoadMetrics.protocol = soup_message_get_http_version(m_soupMessage.get()) == SOUP_HTTP_1_0 ? "http/1.0" : "http/1.1";
> 
> Are libsoup3 and HTTP/2 covered elsewhere?

Not yet.
Comment 8 Carlos Garcia Campos 2021-04-15 01:34:48 PDT
Committed r276009 (236561@main): <https://commits.webkit.org/236561@main>
Comment 9 Joseph Pecoraro 2021-04-26 12:34:18 PDT
Comment on attachment 425972 [details]
Patch

Nice!