Bug 168538 - EWS showing "Patch is not relevant" errors
Summary: EWS showing "Patch is not relevant" errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-17 15:28 PST by Simon Fraser (smfr)
Modified: 2017-02-17 16:50 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-17 15:28:12 PST 
https://webkit-queues.webkit.org/patch/301993

Scripts are throwing errors:

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=ews121', 'check-patch-relevance', '--group=None', '--port=ios-simulator-wk2']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Checking relevance of patch
Traceback (most recent call last):
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py", line 70, in run
    if self._changes_are_relevant(change_list):
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py", line 56, in _changes_are_relevant
    patterns = self.group_to_paths_mapping[self._options.group]
KeyError: 'None'
Comment 1 Srinivasan Vijayaraghavan 2017-02-17 16:34:21 PST 
This was due to a Python NoneType being passed through as a command-line argument, and then being parsed as the string 'None'. Appears fixed for patches uploaded going forward.
Comment 2 Alexey Proskuryakov 2017-02-17 16:50:36 PST 
Aakash says that he already fixed this in http://trac.webkit.org/r212591.