Bug 168534 – Add a new drag code path and use it for dragging plain text

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add a new drag code path and use it for dragging plain text

[Anders Carlsson]

Created attachment 301997 [details]
Patch

[WebKit Commit Bot]

Attachment 301997 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:221:  Missing space around : in range-based for statement  [whitespace/colon] [4]
ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:224:  Extra space in capture list.  [whitespace/brackets] [4]
ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4712:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4714:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/mac/WebCoreSupport/WebDragClient.mm:155:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Created attachment 301998 [details]
Patch

[WebKit Commit Bot]

Attachment 301998 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:221:  Missing space around : in range-based for statement  [whitespace/colon] [4]
ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:224:  Extra space in capture list.  [whitespace/brackets] [4]
ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4712:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4714:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/mac/WebCoreSupport/WebDragClient.mm:155:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Created attachment 302005 [details]
Patch

[WebKit Commit Bot]

Attachment 302005 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:221:  Missing space around : in range-based for statement  [whitespace/colon] [4]
ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:224:  Extra space in capture list.  [whitespace/brackets] [4]
ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4712:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4714:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/mac/WebCoreSupport/WebDragClient.mm:155:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 302005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302005&action=review

> Source/WebCore/page/DragController.cpp:746
> +    float x = (mouseDraggedPoint.x() - draggingRect.x()) / (float)draggingRect.width();
> +    float y = (mouseDraggedPoint.y() - draggingRect.y()) / (float)draggingRect.height();

Do we still like static_cast<float>?

> Source/WebKit/mac/WebCoreSupport/WebDragClient.mm:153
> +    // FIXME: We should be able to make a fake event with the mosue dragged coordinates.

mouse

[Anders Carlsson]

Committed r212663: <http://trac.webkit.org/changeset/212663>