Bug 168529 - Web Inspector: Timeline DataGridNodes are lacking detail in title
Summary: Web Inspector: Timeline DataGridNodes are lacking detail in title
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-17 12:49 PST by Joseph Pecoraro
Modified: 2017-02-17 13:32 PST (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.58 KB, patch)
2017-02-17 12:50 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-02-17 12:49:04 PST 
Timeline DataGridNodes are lacking detail in title

Steps to Reproduce:
1. Inspect LayoutTests/inspector/heap/garbageCollected.html
2. js> periodicallyTriggerGCs()
3. Record Script Timeline
4. Stop Script Timeline
  => Expected details about Partial and Full GCs. Instead they just say "Garbage Collection"

Regression:
- This absolutely was working in the past. Appears to have broken around r194932 / r197909 with Timeline UI changes
Comment 1 Joseph Pecoraro 2017-02-17 12:49:17 PST 
<rdar://problem/30579959>
Comment 2 Joseph Pecoraro 2017-02-17 12:50:22 PST 
Created attachment 301969 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2017-02-17 12:54:17 PST 
Comment on attachment 301969 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2017-02-17 13:31:56 PST 
Comment on attachment 301969 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 301969

Committed r212570: <http://trac.webkit.org/changeset/212570>
Comment 5 WebKit Commit Bot 2017-02-17 13:32:00 PST 
All reviewed patches have been landed.  Closing bug.