RESOLVED FIXED 168527
Improve ARM64 disassembler handling of pseudo ops, unsupported opcodes and zero reg
https://bugs.webkit.org/show_bug.cgi?id=168527
Summary Improve ARM64 disassembler handling of pseudo ops, unsupported opcodes and ze...
Michael Saboff
Reported 2017-02-17 11:15:42 PST
There are several minor issues with the ARM64 disassemble's ability to handle the code we currently generate. The list includes: - Integer extract and rotate immediate opcodes aren't disassembled. - Single source bit operations like CLZ, CLS and REV aren't disassembled. - The conditional instructions like CSEL, CSINC, CSET and FCSEL aren't disassembled. - There are many opcode where we print X31/W31 instead of XZR/WZR for the zero register. - For register index load and store instruction, we print the zero register when the convention is that we should omit. - Several pseudo instructions are handled MVN Xd, Xn in place of ORN Xd, XZR, Xn LSL Xd, Xn, #count in place of UBFIZ Xd, Xn, #count, #count SMULL Xd, Wn, Wm in place of SMADDL Xd, Wn, Wm, XZR
Attachments
Patch (25.73 KB, patch)
2017-02-17 12:01 PST, Michael Saboff
fpizlo: review+
buildbot: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2 (938.24 KB, application/zip)
2017-02-17 13:06 PST, Build Bot
no flags
Michael Saboff
Comment 1 2017-02-17 12:01:46 PST
Build Bot
Comment 2 2017-02-17 13:06:45 PST
Comment on attachment 301966 [details] Patch Attachment 301966 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3144728 New failing tests: scrollingcoordinator/ios/non-stable-viewport-scroll.html
Build Bot
Comment 3 2017-02-17 13:06:48 PST
Created attachment 301974 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Michael Saboff
Comment 4 2017-02-17 15:53:58 PST
Note You need to log in before you can comment on or make changes to this bug.