Bug 168511 - Remove EFL from WebKit2
Summary: Remove EFL from WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-17 06:39 PST by Michael Catanzaro
Modified: 2017-02-17 11:47 PST (History)
6 users (show)

See Also:


Attachments
Patch (63.64 KB, patch)
2017-02-17 06:41 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (63.67 KB, patch)
2017-02-17 07:21 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-02-17 06:39:04 PST
Remove EFL from WebKit2
Comment 1 Michael Catanzaro 2017-02-17 06:41:03 PST
Created attachment 301921 [details]
Patch
Comment 2 Michael Catanzaro 2017-02-17 07:21:27 PST
Created attachment 301930 [details]
Patch
Comment 3 Alex Christensen 2017-02-17 10:46:26 PST
Comment on attachment 301930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301930&action=review

Thanks!

> Source/WebKit2/UIProcess/CoordinatedGraphics/PageViewportController.cpp:87
>  FloatPoint PageViewportController::pixelAlignedFloatPoint(const FloatPoint& framePosition)

This could probably be further simplified.
Comment 4 WebKit Commit Bot 2017-02-17 11:12:21 PST
Comment on attachment 301930 [details]
Patch

Clearing flags on attachment: 301930

Committed r212557: <http://trac.webkit.org/changeset/212557>
Comment 5 WebKit Commit Bot 2017-02-17 11:12:26 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Michael Catanzaro 2017-02-17 11:47:05 PST
(In reply to comment #3)
> > Source/WebKit2/UIProcess/CoordinatedGraphics/PageViewportController.cpp:87
> >  FloatPoint PageViewportController::pixelAlignedFloatPoint(const FloatPoint& framePosition)
> 
> This could probably be further simplified.

Good point, considering the function is a no-op now. Some of the uses of it are not trivial though, e.g. there is the comment "The scale changed, we have to re-pixel align." So it'd be good if someone with graphics expertise could look into this.