Bug 168509 - [SOUP] Stop removing the fragment identifier from resource requests
Summary: [SOUP] Stop removing the fragment identifier from resource requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-02-17 06:09 PST by Carlos Garcia Campos
Modified: 2017-02-17 07:17 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2017-02-17 06:12 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2017-02-17 06:13 PST, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-17 06:09:52 PST 
I don't know why, but have always removed the fragment identifiers from the URL when creating the SoupURI that is passed to libsoup. Maybe it was a bug in a very old version of libsoup, but it doesn't look necessary anymore and it's causing several layout tests failures.
Comment 1 Carlos Garcia Campos 2017-02-17 06:12:25 PST 
Created attachment 301918 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-17 06:13:38 PST 
Created attachment 301919 [details]
Patch
Comment 3 Carlos Garcia Campos 2017-02-17 06:48:26 PST 
Committed r212548: <http://trac.webkit.org/changeset/212548>
Comment 4 Martin Robinson 2017-02-17 06:50:14 PST 
Out of curiosity I tracked down this behavior to:
https://trac.webkit.org/changeset/41058

Here's the original comment:
    // GIO doesn't know how to handle refs and queries, so remove them 
    // TODO: use KURL.fileSystemPath after KURLGtk and FileSystemGtk are 
    // using GIO internally, and providing URIs instead of file paths
Comment 5 Martin Robinson 2017-02-17 06:51:29 PST 
The origin of the behavior is here: https://trac.webkit.org/changeset/33594
Comment 6 Carlos Garcia Campos 2017-02-17 06:55:23 PST 
(In reply to comment #4)
> Out of curiosity I tracked down this behavior to:
> https://trac.webkit.org/changeset/41058
> 
> Here's the original comment:
>     // GIO doesn't know how to handle refs and queries, so remove them 
>     // TODO: use KURL.fileSystemPath after KURLGtk and FileSystemGtk are 
>     // using GIO internally, and providing URIs instead of file paths

But I think this was only done for local files. This code was removed actually. For URLS we have always done it.
Comment 7 Michael Catanzaro 2017-02-17 07:17:05 PST 
So this is why anchor links have always been buggy for us...? WTF. :(