Bug 168497 - Web Inspector: RTL: Settings tab labels need adjustment
Summary: Web Inspector: RTL: Settings tab labels need adjustment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 22:58 PST by Matt Baker
Modified: 2017-02-22 09:58 PST (History)
3 users (show)

See Also:

Attachments
[Image] Settings tab w/ RTL layout (223.69 KB, image/png)
2017-02-16 22:58 PST, Matt Baker 		no flags Details
Patch (4.10 KB, patch)
2017-02-22 07:15 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Settings Tab (RTL) (119.80 KB, image/png)
2017-02-22 07:15 PST, BJ Burg 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-02-16 22:58:29 PST 
Created attachment 301886 [details]
[Image] Settings tab w/ RTL layout

Labels should be left aligned now that they're in the rightmost column.
Comment 1 BJ Burg 2017-02-22 07:15:26 PST 
Created attachment 302400 [details]
Patch
Comment 2 BJ Burg 2017-02-22 07:15:55 PST 
Created attachment 302401 [details]
Settings Tab (RTL)
Comment 3 BJ Burg 2017-02-22 07:16:59 PST 
Comment on attachment 302401 [details]
Settings Tab (RTL)

Note that the string parentheses bug in the Layout Direction select is a WebCore text rendering bug, per Myles.
Comment 4 Matt Baker 2017-02-22 09:31:11 PST 
Comment on attachment 302400 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2017-02-22 09:58:38 PST 
Comment on attachment 302400 [details]
Patch

Clearing flags on attachment: 302400

Committed r212838: <http://trac.webkit.org/changeset/212838>
Comment 6 WebKit Commit Bot 2017-02-22 09:58:42 PST 
All reviewed patches have been landed.  Closing bug.