Bug 168492 - Use expect.js instead of expect in browser tests
Summary: Use expect.js instead of expect in browser tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 19:54 PST by Ryosuke Niwa
Modified: 2017-02-16 21:37 PST (History)
3 users (show)

See Also:


Attachments
Replaces the library (32.36 KB, patch)
2017-02-16 19:59 PST, Ryosuke Niwa
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-02-16 19:54:09 PST
The perf dashboard's browser tests should be using expect.js, not expect.
Comment 1 Ryosuke Niwa 2017-02-16 19:59:05 PST
Created attachment 301872 [details]
Replaces the library
Comment 2 Joseph Pecoraro 2017-02-16 20:02:57 PST
Comment on attachment 301872 [details]
Replaces the library

View in context: https://bugs.webkit.org/attachment.cgi?id=301872&action=review

rs=me

> Websites/perf.webkit.org/browser-tests/editable-text-tests.js:80
> +            return waitCopmonentToRender(context);

Typo: "Copmonent" => "Component"

Maybe instead of "waitComponentToRender" this should be "waitForComponentToRender" ?
Comment 3 Ryosuke Niwa 2017-02-16 21:35:34 PST
Actually, they should be waitForComponentsToRender since it waits for all components that got enqueued to render instead of just a specific component to render.

Thanks for the review!
Comment 4 Ryosuke Niwa 2017-02-16 21:37:46 PST
Committed r212533: <http://trac.webkit.org/changeset/212533>