Bug 168484 - Modernize and fix measurement-set tests
Summary: Modernize and fix measurement-set tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 17:08 PST by Ryosuke Niwa
Modified: 2017-02-16 19:51 PST (History)
2 users (show)

See Also:


Attachments
Patch (42.19 KB, patch)
2017-02-16 17:27 PST, Ryosuke Niwa
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-02-16 17:08:23 PST
New version of node which reports unhandled promises found a bunch of bugs in measurement-set-tests.js.
Fix the tests and also fix a tiny bug in hasFetchedRange I found by fixing the tests.
Comment 1 Ryosuke Niwa 2017-02-16 17:27:04 PST
Created attachment 301865 [details]
Patch
Comment 2 Joseph Pecoraro 2017-02-16 19:46:41 PST
Comment on attachment 301865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301865&action=review

r=me

> Websites/perf.webkit.org/unit-tests/measurement-set-tests.js:114
> +        it('should invoke the callback and fetch a secondary cluster when the cached primary cluster is within in the requested range', () => {

Typo: "is within in" => "is within"
Comment 3 Ryosuke Niwa 2017-02-16 19:51:51 PST
Committed r212520: <http://trac.webkit.org/changeset/212520>