Bug 168474 – [WebRTC] libwebrtc socket addresses should not be passed as strings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[youenn fablet]

There is loss of information that might trigger bugs in libwebrtc network stack.

[youenn fablet]

Created attachment 301840 [details]
Patch

[WebKit Commit Bot]

Attachment 301840 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/RTCNetwork.h:62:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 301840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301840&action=review

> Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:64
> +    callOnMainThread([identifier = socket->identifier(), address, minPort, maxPort]() {

Let's make an isolatedCopy

[youenn fablet]

Created attachment 301859 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 301859 [details]
Patch for landing

Rejecting attachment 301859 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 301859, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit2/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3135895

[youenn fablet]

Created attachment 301866 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 301866 [details]
Patch for landing

Clearing flags on attachment: 301866

Committed r212519: <http://trac.webkit.org/changeset/212519>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.