Bug 168465 – Web Inspector: Loc: Zoom level in Settings tab needs to use localized formatting

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Intl to the rescue!

[Blaze Burg]

STEPS TO REPRODUCE:
- Open Settings Tab
- Look at Zoom Level: section

EXPECTED:

With en-US locale, should be 100%, 120%, etc.
With tr-TR locale, should be %100, %120, etc.

[Blaze Burg]

Created attachment 301823 [details]
[AFTER] tr-TR locale

[Blaze Burg]

Created attachment 301824 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 301824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301824&action=review

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:188
> -                option.textContent = `${Math.round(level * 100)}%`;
> +                option.textContent = formatter.format(level);

We have Number.percentageString in Utilities.js. Should we just use that?

[Blaze Burg]

(In reply to comment #4)
> Comment on attachment 301824 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301824&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:188
> > -                option.textContent = `${Math.round(level * 100)}%`;
> > +                option.textContent = formatter.format(level);
> 
> We have Number.percentageString in Utilities.js. Should we just use that?

Had no idea. Yes, it works the same it seems.

[Blaze Burg]

Created attachment 301836 [details]
Patch v2

[Matt Baker]

Comment on attachment 301836 [details]
Patch v2

Text isn't being localized with the patch applied

[Blaze Burg]

(In reply to comment #1)
> STEPS TO REPRODUCE:
> - Open Settings Tab
> - Look at Zoom Level: section
> 
> EXPECTED:
> 
> With en-US locale, should be 100%, 120%, etc.
> With tr-TR locale, should be %100, %120, etc.

To get tr-TR locale on macOS, go to System Preferences > Language & Region and add Turkish/Türkçe, then drag it to the top position. Relaunch Safari.

[Blaze Burg]

(In reply to comment #7)
> Comment on attachment 301836 [details]
> Patch v2
> 
> Text isn't being localized with the patch applied

It works for me. Did you change the system language?

[Matt Baker]

(In reply to comment #9)
> (In reply to comment #7)
> > Comment on attachment 301836 [details]
> > Patch v2
> > 
> > Text isn't being localized with the patch applied
> 
> It works for me. Did you change the system language?

Works! My mistake.

[WebKit Commit Bot]

Comment on attachment 301836 [details]
Patch v2

Clearing flags on attachment: 301836

Committed r212578: <http://trac.webkit.org/changeset/212578>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.