Bug 168456 - Remove unused method WKBundlePageCopyContextMenuItemTitle
Summary: Remove unused method WKBundlePageCopyContextMenuItemTitle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 12:58 PST by Aakash Jain
Modified: 2017-02-16 15:28 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (2.18 KB, patch)
2017-02-16 13:05 PST, Aakash Jain 		mitz: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-elcapitan (1.51 MB, application/zip)
2017-02-16 14:37 PST, Build Bot 		no flags Details
Updated patch (1.48 KB, patch)
2017-02-16 14:49 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-02-16 12:58:49 PST 
WKBundlePageCopyContextMenuItemTitle method declaration in WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h is unused. It doesn't have corresponding definition. Seems like it was added by mistake in https://bugs.webkit.org/show_bug.cgi?id=98410
Comment 1 Aakash Jain 2017-02-16 13:05:22 PST 
Created attachment 301806 [details]
Proposed patch
Comment 2 Build Bot 2017-02-16 14:37:47 PST 
Comment on attachment 301806 [details]
Proposed patch

Attachment 301806 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3134949

New failing tests:
imported/w3c/web-platform-tests/resource-timing/rt-resource-ignored.html
Comment 3 Build Bot 2017-02-16 14:37:50 PST 
Created attachment 301827 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Aakash Jain 2017-02-16 14:49:30 PST 
Created attachment 301829 [details]
Updated patch
Comment 5 WebKit Commit Bot 2017-02-16 15:28:35 PST 
Comment on attachment 301829 [details]
Updated patch

Clearing flags on attachment: 301829

Committed r212475: <http://trac.webkit.org/changeset/212475>
Comment 6 WebKit Commit Bot 2017-02-16 15:28:38 PST 
All reviewed patches have been landed.  Closing bug.