168455 – [JSC] Drop PassRefPtr from ArrayBuffer

RESOLVED FIXED 168455

[JSC] Drop PassRefPtr from ArrayBuffer

https://bugs.webkit.org/show_bug.cgi?id=168455

Summary [JSC] Drop PassRefPtr from ArrayBuffer

Yusuke Suzuki

Reported 2017-02-16 12:55:32 PST

[JSC] Drop PassRefPtr from ArrayBuffer

Attachments
Patch (49.77 KB, patch) 2017-02-16 12:59 PST, Yusuke Suzuki	ggaren: review+	Details Formatted Diff Diff
Patch (57.11 KB, patch) 2017-02-16 13:19 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (57.47 KB, patch) 2017-02-16 13:51 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (57.95 KB, patch) 2017-02-16 19:37 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (57.99 KB, patch) 2017-02-16 20:42 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (58.09 KB, patch) 2017-02-16 20:59 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2017-02-16 12:59:23 PST

Created attachment 301804 [details] Patch

WebKit Commit Bot

Comment 2 2017-02-16 13:00:42 PST

Attachment 301804 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 3 2017-02-16 13:07:49 PST

Comment on attachment 301804 [details] Patch r=me

Yusuke Suzuki

Comment 4 2017-02-16 13:19:23 PST

Created attachment 301809 [details] Patch Patch for landing with macOS fix

WebKit Commit Bot

Comment 5 2017-02-16 13:22:53 PST

Attachment 301809 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 6 2017-02-16 13:51:15 PST

Created attachment 301818 [details] Patch Patch for landing with macOS fix

WebKit Commit Bot

Comment 7 2017-02-16 13:53:15 PST

Attachment 301818 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 8 2017-02-16 19:37:35 PST

Created attachment 301871 [details] Patch Patch for landing with macOS linker fix

WebKit Commit Bot

Comment 9 2017-02-16 19:40:39 PST

Attachment 301871 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 10 2017-02-16 20:42:29 PST

Created attachment 301874 [details] Patch Patch for landing with macOS linker fix

WebKit Commit Bot

Comment 11 2017-02-16 20:45:47 PST

Attachment 301874 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 12 2017-02-16 20:59:16 PST

Created attachment 301876 [details] Patch Patch for landing with macOS linker fix

WebKit Commit Bot

Comment 13 2017-02-16 21:09:38 PST

Attachment 301876 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 14 2017-02-16 22:06:03 PST

Committed r212535: <http://trac.webkit.org/changeset/212535>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Yusuke Suzuki

Reported

2017-02-16 12:55 PST

Modified

2017-02-16 22:06 PST History

CC List

6 users Show

URL

Keywords

Depends on

Blocks