Bug 168455 - [JSC] Drop PassRefPtr from ArrayBuffer
Summary: [JSC] Drop PassRefPtr from ArrayBuffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 12:55 PST by Yusuke Suzuki
Modified: 2017-02-16 22:06 PST (History)
6 users (show)

See Also:

Attachments
Patch (49.77 KB, patch)
2017-02-16 12:59 PST, Yusuke Suzuki 		ggaren: review+
Details | Formatted Diff | Diff
Patch (57.11 KB, patch)
2017-02-16 13:19 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (57.47 KB, patch)
2017-02-16 13:51 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (57.95 KB, patch)
2017-02-16 19:37 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (57.99 KB, patch)
2017-02-16 20:42 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (58.09 KB, patch)
2017-02-16 20:59 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-02-16 12:55:32 PST 
[JSC] Drop PassRefPtr from ArrayBuffer
Comment 1 Yusuke Suzuki 2017-02-16 12:59:23 PST 
Created attachment 301804 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-16 13:00:42 PST 
Attachment 301804 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2017-02-16 13:07:49 PST 
Comment on attachment 301804 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2017-02-16 13:19:23 PST 
Created attachment 301809 [details]
Patch

Patch for landing with macOS fix
Comment 5 WebKit Commit Bot 2017-02-16 13:22:53 PST 
Attachment 301809 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Yusuke Suzuki 2017-02-16 13:51:15 PST 
Created attachment 301818 [details]
Patch

Patch for landing with macOS fix
Comment 7 WebKit Commit Bot 2017-02-16 13:53:15 PST 
Attachment 301818 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Yusuke Suzuki 2017-02-16 19:37:35 PST 
Created attachment 301871 [details]
Patch

Patch for landing with macOS linker fix
Comment 9 WebKit Commit Bot 2017-02-16 19:40:39 PST 
Attachment 301871 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Yusuke Suzuki 2017-02-16 20:42:29 PST 
Created attachment 301874 [details]
Patch

Patch for landing with macOS linker fix
Comment 11 WebKit Commit Bot 2017-02-16 20:45:47 PST 
Attachment 301874 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Yusuke Suzuki 2017-02-16 20:59:16 PST 
Created attachment 301876 [details]
Patch

Patch for landing with macOS linker fix
Comment 13 WebKit Commit Bot 2017-02-16 21:09:38 PST 
Attachment 301876 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Yusuke Suzuki 2017-02-16 22:06:03 PST 
Committed r212535: <http://trac.webkit.org/changeset/212535>