Bug 168439 - [WK2] Add additional test infrastructure and unit tests for data interaction
Summary: [WK2] Add additional test infrastructure and unit tests for data interaction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-16 09:42 PST by Wenson Hsieh
Modified: 2017-02-16 17:34 PST (History)
5 users (show)

See Also:

Attachments
Patch (34.75 KB, patch)
2017-02-16 14:50 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-02-16 09:42:40 PST 
Add additional test infrastructure and unit tests for data interaction.
Comment 1 Wenson Hsieh 2017-02-16 14:44:31 PST 
<rdar://problem/30557942>
Comment 2 Wenson Hsieh 2017-02-16 14:50:33 PST 
Created attachment 301830 [details]
Patch
Comment 3 Tim Horton 2017-02-16 16:38:44 PST 
Comment on attachment 301830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301830&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2982
> +				"OTHER_LDFLAGS_PLATFORM[sdk=iphone*]" = "-framework WebCore -framework CoreGraphics -framework UIKit -framework MobileCoreServices";

Pretty sure this should be in an xcconfig somewhere?
Comment 4 Wenson Hsieh 2017-02-16 16:47:17 PST 
(In reply to comment #3)
> Comment on attachment 301830 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301830&action=review
> 
> > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2982
> > +				"OTHER_LDFLAGS_PLATFORM[sdk=iphone*]" = "-framework WebCore -framework CoreGraphics -framework UIKit -framework MobileCoreServices";
> 
> Pretty sure this should be in an xcconfig somewhere?

Oh, good point! Added "-framework MobileCoreServices" to TestWebKitAPI.xcconfig instead.
Comment 5 Wenson Hsieh 2017-02-16 17:34:06 PST 
Committed <http://trac.webkit.org/changeset/212507>