Bug 168433 - [GTK] Lack of support for CrossOriginPreflight XHR request
Summary: [GTK] Lack of support for CrossOriginPreflight XHR request
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 07:11 PST by Javier Fernandez
Modified: 2017-03-11 11:04 PST (History)
3 users (show)

See Also:


Attachments
Current diff of the test failure. (9.80 KB, text/html)
2017-02-16 08:43 PST, Javier Fernandez
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2017-02-16 07:11:39 PST
The change in r204795 added support on WebCore for redirect post CORS-preflight requests.
This enabled to follow cross-origin redirections for not-simple requests, through preflight checks.

We were not processing the non-simple request on http/tests/xmlhttprequest/redirections-and-user-headers.html fails because of this, but now they are being processed.

I don t think such test fails because of that, but it definitively triggered some missing features of the GTK port.
Comment 1 Javier Fernandez 2017-02-16 07:12:28 PST
Please, Youenn, if you have time take a look.
Comment 2 youenn fablet 2017-02-16 08:19:30 PST
This code should be cross-platform but hey, we never know!
Looking at the current GTK result, it does not seem related to CORS/preflight since one same-origin redirection test is not passing either (Authentication header present).

Is r204795 regressing the test in GTK?
Comment 3 Javier Fernandez 2017-02-16 08:39:03 PST
(In reply to comment #2)
> This code should be cross-platform but hey, we never know!
> Looking at the current GTK result, it does not seem related to
> CORS/preflight since one same-origin redirection test is not passing either
> (Authentication header present).
> 
> Is r204795 regressing the test in GTK?

Not exactly. The test was already failing before r204795 but with a different error. I think the new errors come from the fact that after r204795 we allow  same-origin redirections for non-simple requests. 

My request for review would be more to get some clue about what webkitgtk could be missing to cause the current failure of this test.
Comment 4 Javier Fernandez 2017-02-16 08:43:00 PST
Created attachment 301771 [details]
Current diff of the test failure.