Bug 168421 - <input type=color readonly> doesn't act per spec
Summary: <input type=color readonly> doesn't act per spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-16 04:53 PST by Simon Pieters (:zcorpan)
Modified: 2017-02-19 16:48 PST (History)
8 users (show)

See Also:


Attachments
Patch (7.50 KB, patch)
2017-02-18 22:03 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-elcapitan (1.71 MB, application/zip)
2017-02-19 01:21 PST, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (842.33 KB, application/zip)
2017-02-19 01:22 PST, Build Bot
no flags Details
Patch (9.36 KB, patch)
2017-02-19 16:11 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pieters (:zcorpan) 2017-02-16 04:53:26 PST
(This issue for Chromium was fixed in 2013: https://bugs.chromium.org/p/chromium/issues/detail?id=249515 )

TESTCASE: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=2319

The "readonly" attribute on <input type=color> is supposed to be ignored, but WebKit makes it stop popping up the color picker yet without making the control stop being interactive, so it just looks broken.

In Chromium/Gecko/Edge/HTML standard, readonly does not apply to type=color.

[[
The following content attributes must not be specified and do not apply to the element: ... readonly, ...
]]
https://html.spec.whatwg.org/#color-state-(type=color)
Comment 1 Radar WebKit Bug Importer 2017-02-18 15:12:06 PST
<rdar://problem/30593185>
Comment 2 Chris Dumez 2017-02-18 22:03:33 PST
Created attachment 302068 [details]
Patch
Comment 3 Build Bot 2017-02-19 01:21:25 PST
Comment on attachment 302068 [details]
Patch

Attachment 302068 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3153237

New failing tests:
fast/forms/color/input-color-readonly.html
Comment 4 Build Bot 2017-02-19 01:21:29 PST
Created attachment 302070 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-02-19 01:22:37 PST
Comment on attachment 302068 [details]
Patch

Attachment 302068 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3153242

New failing tests:
fast/forms/color/input-color-readonly.html
Comment 6 Build Bot 2017-02-19 01:22:41 PST
Created attachment 302071 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Chris Dumez 2017-02-19 16:11:00 PST
Created attachment 302097 [details]
Patch
Comment 8 WebKit Commit Bot 2017-02-19 16:48:11 PST
Comment on attachment 302097 [details]
Patch

Clearing flags on attachment: 302097

Committed r212617: <http://trac.webkit.org/changeset/212617>
Comment 9 WebKit Commit Bot 2017-02-19 16:48:17 PST
All reviewed patches have been landed.  Closing bug.