RESOLVED FIXED 168412
Local audio-only stream will not trigger playback to begin
https://bugs.webkit.org/show_bug.cgi?id=168412
Summary Local audio-only stream will not trigger playback to begin
Jer Noble
Reported 2017-02-15 21:42:30 PST
Local audio-only stream will not trigger playback to begin
Attachments
Patch (8.29 KB, patch)
2017-02-15 21:53 PST, Jer Noble
youennf: review+
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan (903.90 KB, application/zip)
2017-02-15 22:56 PST, Build Bot
no flags
Archive of layout-test-results from ews115 for mac-elcapitan (1.65 MB, application/zip)
2017-02-16 03:09 PST, Build Bot
no flags
Patch for landing (8.28 KB, patch)
2017-02-17 09:11 PST, Jer Noble
buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.10 MB, application/zip)
2017-02-17 09:53 PST, Build Bot
no flags
Patch for landing (8.34 KB, patch)
2017-02-20 16:06 PST, Jer Noble
no flags
Radar WebKit Bug Importer
Comment 1 2017-02-15 21:48:31 PST
Jer Noble
Comment 2 2017-02-15 21:53:09 PST
youenn fablet
Comment 3 2017-02-15 22:01:36 PST
Comment on attachment 301707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301707&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:863 > + track->streamTrack().addObserver(*this); Shouldn't we stop observing the track when removing it just above?
Build Bot
Comment 4 2017-02-15 22:56:47 PST
Comment on attachment 301707 [details] Patch Attachment 301707 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3126589 New failing tests: streams/local-audio-playing-event.html
Build Bot
Comment 5 2017-02-15 22:56:51 PST
Created attachment 301714 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-02-16 03:09:12 PST
Comment on attachment 301707 [details] Patch Attachment 301707 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3132337 New failing tests: streams/local-audio-playing-event.html
Build Bot
Comment 7 2017-02-16 03:09:16 PST
Created attachment 301730 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Jer Noble
Comment 8 2017-02-17 09:11:00 PST
Created attachment 301939 [details] Patch for landing
Jer Noble
Comment 9 2017-02-17 09:11:49 PST
Previous test errors were because those EWS bots run in WK1 mode, where MediaStream is not supported. Moved the test to the fast/mediastream/ directory, which is skipped on WK1 test runs.
Build Bot
Comment 10 2017-02-17 09:53:34 PST
Comment on attachment 301939 [details] Patch for landing Attachment 301939 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3143932 New failing tests: fast/mediastream/local-audio-playing-event.html
Build Bot
Comment 11 2017-02-17 09:53:37 PST
Created attachment 301948 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Jer Noble
Comment 12 2017-02-20 16:06:11 PST
Created attachment 302190 [details] Patch for landing Fixed the relative paths which broke when the layout test was moved to a different, deeper directory.
WebKit Commit Bot
Comment 13 2017-02-20 18:37:20 PST
Comment on attachment 302190 [details] Patch for landing Clearing flags on attachment: 302190 Committed r212696: <http://trac.webkit.org/changeset/212696>
Note You need to log in before you can comment on or make changes to this bug.