Refactor AccessCase to be more like B3Value
Created attachment 301700 [details] Patch
Created attachment 301775 [details] Patch
Attachment 301775 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:47: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:55: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:64: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 3 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 301775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301775&action=review > Source/JavaScriptCore/bytecode/AccessCase.cpp:160 > +IntrinsicGetterAccessCase::~IntrinsicGetterAccessCase() Can we put these in separate files named after the class?
Created attachment 301776 [details] Patch
(In reply to comment #4) > Comment on attachment 301775 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301775&action=review > > > Source/JavaScriptCore/bytecode/AccessCase.cpp:160 > > +IntrinsicGetterAccessCase::~IntrinsicGetterAccessCase() > > Can we put these in separate files named after the class? done.
Created attachment 301779 [details] Patch for landing
Attachment 301779 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:47: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:55: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/bytecode/AccessCase.h:64: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r212453: <http://trac.webkit.org/changeset/212453>