Bug 168402 – JSC: fix compilation errors for MIPS

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Guillaume Emont]

This is to introduce a patch that fixes misceallaneous issues for MIPS compilation (small missing bits).

[Guillaume Emont]

Created attachment 301689 [details]
Patch

Patch by Suresh Kumar with small modifications by myself.

[Guillaume Emont]

(In reply to comment #1)
> Created attachment 301689 [details]
> Patch
> 
> Patch by Suresh Kumar with small modifications by myself.

Note that there is a style error in the order of includes in MacroAssemblerMIPS.h. I don't know how to solve it since compilation fails if the includes are in the opposite order. I imagine this means we miss an include somewhere, but I could not find which one so far.

[WebKit Commit Bot]

Attachment 301689 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Guillaume Emont]

(In reply to comment #2)

> Note that there is a style error in the order of includes in
> MacroAssemblerMIPS.h. I don't know how to solve it since compilation fails
> if the includes are in the opposite order. I imagine this means we miss an
> include somewhere, but I could not find which one so far.

Note that MacroAssemblerX86Common.h has the same non-alphabetical order of includes.

[Guillaume Emont]

Just fount that the header issue is due to AbstractMacroAssembler.h not including wtf/Vector.h, which means in some cases its use of Vector ends up using the template in wtf/Forward.h which requires 4 arguments. Will send a patch for that later tonight or tomorrow.

[Guillaume Emont]

I proposed a patch for the header issue in https://bugs.webkit.org/show_bug.cgi?id=168537 but it seems to create compilation issues on Mac so I think I need to examine that further.

[Guillaume Emont]

After further investigation, I don't think there is an easy fix for the header issue. Can this patch be accepted despite this issue?

[Mark Lam]

Comment on attachment 301689 [details]
Patch

rs=me

[WebKit Commit Bot]

Comment on attachment 301689 [details]
Patch

Clearing flags on attachment: 301689

Committed r213881: <http://trac.webkit.org/changeset/213881>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.