Bug 168395 - [MediaStream] delete CaptureDeviceInfo struct
Summary: [MediaStream] delete CaptureDeviceInfo struct
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-15 15:06 PST by Eric Carlson
Modified: 2017-02-15 18:03 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch (20.46 KB, patch)
2017-02-15 15:23 PST, Eric Carlson
sam: review+
Details | Formatted Diff | Diff
Patch for landing. (20.88 KB, patch)
2017-02-15 16:39 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2017-02-15 15:06:42 PST
Use the existing CaptureDevice class.
Comment 1 Radar WebKit Bug Importer 2017-02-15 15:09:38 PST
<rdar://problem/30544426>
Comment 2 Eric Carlson 2017-02-15 15:23:58 PST
Created attachment 301663 [details]
Proposed patch
Comment 3 Sam Weinig 2017-02-15 16:01:59 PST
Comment on attachment 301663 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301663&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests, no behavior change.
> +
> +        * Modules/mediastream/MediaDevicesRequest.cpp:
> +        (WebCore::MediaDevicesRequest::start):

ChangeLog could use more information, since you are doing more than just deleting a struct.
Comment 4 Eric Carlson 2017-02-15 16:39:21 PST
Created attachment 301672 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2017-02-15 18:03:39 PST
Comment on attachment 301672 [details]
Patch for landing.

Clearing flags on attachment: 301672

Committed r212418: <http://trac.webkit.org/changeset/212418>