Simulated iPad Pro look have parenthesis in their names when listed through xcrun simctl list. An example of an iPad Pro simulator name is bellow: iPad Pro (9.7 inch) (udid) (state) The regular expression which parses these lines does not consider devices with names which have parenthesis in them.
Created attachment 301660 [details] Patch
Comment on attachment 301660 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301660&action=review > Tools/Scripts/webkitpy/xcode/simulator.py:344 > - '\s*(?P<name>[^(]+ )\((?P<udid>[^)]+)\) \((?P<state>[^)]+)\)( \((?P<availability>[^)]+)\))?') > + '\s*(?P<name>.+) \((?P<udid>[^)]+)\) \((?P<state>[^)]+)\)( \((?P<availability>[^)]+)\))?') Is this testable?
Ideally, we should switch to JSON, not polish text output parsing.
(In reply to comment #3) > Ideally, we should switch to JSON, not polish text output parsing. I agree that the JSON would be preferable, but I also think that we should at least fix this regular expression temporarily. It will be a few more weeks before the JSON change gets made, and currently, many of the default iPad names do not fit into our regular expression.
Created attachment 302336 [details] Patch
Comment on attachment 302336 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302336&action=review > Tools/ChangeLog:3 > + webkitpy: Regular expression for parsing simctl device information is wrong for iPad pros iPad pros => iPad Pro
Created attachment 302965 [details] Patch for landing
Comment on attachment 302965 [details] Patch for landing Clearing flags on attachment: 302965 Committed r213164: <http://trac.webkit.org/changeset/213164>
All reviewed patches have been landed. Closing bug.