Bug 168385 – Web Inspector: Split console should be allowed when docked bottom on Elements/Resources/Debugger/Storage tabs

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Issue caused by r210911 <https://webkit.org/b/167075>.

[Devin Rousso]

Created attachment 301655 [details]
Patch

[Matt Baker]

Comment on attachment 301655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301655&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js:52
> +    get supportsSplitContentBrowser()

This override and the three that follow could be eliminated by changing ContentView.prototype.supportsSplitContentBrowser back to `return true`. This should work because of your change above.

[Devin Rousso]

Comment on attachment 301655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301655&action=review

>> Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js:52
>> +    get supportsSplitContentBrowser()
> 
> This override and the three that follow could be eliminated by changing ContentView.prototype.supportsSplitContentBrowser back to `return true`. This should work because of your change above.

I figured that it would be safer to make the default functionality be no split console when docked bottom and use a whitelist style of enabling tabs that we know work.  Then again we don't have many tabs so this doesn't matter too much.  If you would prefer it to be switched then I can change it  :D

[WebKit Commit Bot]

Comment on attachment 301655 [details]
Patch

Clearing flags on attachment: 301655

Committed r212400: <http://trac.webkit.org/changeset/212400>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.