WKWebView inside a UICollectionView flashes when items are inserted above it
Created attachment 301627 [details] Patch
Comment on attachment 301627 [details] Patch Attachment 301627 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3122794 New failing tests: scrollingcoordinator/ios/sync-layer-positions-after-scroll.html scrollingcoordinator/ios/non-stable-viewport-scroll.html
Created attachment 301634 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Gonna need Simon's help with that one.
Created attachment 301643 [details] Patch
Comment on attachment 301643 [details] Patch Attachment 301643 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3123568 New failing tests: fast/text-autosizing/ios/autosize-width.html
Created attachment 301646 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 301668 [details] Patch
Attachment 301668 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:292: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 301668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301668&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2216 > + [webView _updateContentRectsWithState:!webView->_hasScheduledVisibleContentRectUpdateFromScrollViewInUnstableState]; It seems a little silly to pass state to _updateContentRectsWithState: which webView has internally. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2322 > + _visibleContentRectUpdateCallbacks.takeLast()(); Took me two reads to see ()() Maybe auto callback = _visibleContentRectUpdateCallbacks.takeLast(); callback();
(In reply to comment #10) > Comment on attachment 301668 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301668&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2216 > > + [webView _updateContentRectsWithState:!webView->_hasScheduledVisibleContentRectUpdateFromScrollViewInUnstableState]; > > It seems a little silly to pass state to _updateContentRectsWithState: which > webView has internally. > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2322 > > + _visibleContentRectUpdateCallbacks.takeLast()(); > > Took me two reads to see ()() > Maybe auto callback = _visibleContentRectUpdateCallbacks.takeLast(); > callback(); Both fair points, I will fix them (and wait for the bots).
Comment on attachment 301668 [details] Patch Attachment 301668 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3125027 New failing tests: scrollingcoordinator/ios/sync-layer-positions-after-scroll.html pageoverlay/overlay-remove-reinsert-view.html
Created attachment 301675 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 301686 [details] Patch
Comment on attachment 301686 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301686&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2212 > + return; > + _hasInstalledPreCommitHandlerForVisibleRectUpdate = YES; Blank line after the return please.
Created attachment 301690 [details] Patch
Attachment 301690 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:292: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 301690 [details] Patch Attachment 301690 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3126051 New failing tests: fast/text-autosizing/ios/autosize-width.html
Created attachment 301698 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
This one makes even less sense.
Created attachment 301798 [details] Patch
Attachment 301798 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:292: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
https://trac.webkit.org/changeset/212459