Bug 168368 - Remove WebIOSEvent interface
Summary: Remove WebIOSEvent interface
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Depends on:
Reported: 2017-02-15 07:31 PST by Aakash Jain
Modified: 2017-02-15 10:15 PST (History)
8 users (show)

See Also:

Proposed patch (10.04 KB, patch)
2017-02-15 07:45 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-02-15 07:31:37 PST
WebIOSEvent interface in WebCore/platform/ios/WebEvent.h is just a wrapper on top of WebEvent. This interface doesn't declare anything new and doesn't even have an implementation. We should use WebEvent directly.
Comment 1 Aakash Jain 2017-02-15 07:45:15 PST
Created attachment 301618 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2017-02-15 07:46:26 PST
Attachment 301618 [details] did not pass style-queue:

ERROR: Source/WebKit2/Shared/ios/WebIOSEventFactory.h:36:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-02-15 09:10:53 PST
Comment on attachment 301618 [details]
Proposed patch

What's with all the ::?  I thought ObjC classes don't have namespaces.  Is there something else named WebEvent?
Comment 4 Alexey Proskuryakov 2017-02-15 09:33:52 PST
The immediate problem with WebIOSEvent is that it has no implementation, and thus breaks InstallAPI. That could be addressed by adding an implementation.

But both Aakash and I think that subclassing shouldn't be used just to disambiguate names. Thoughts?
Comment 5 Alexey Proskuryakov 2017-02-15 09:36:43 PST
And yes, this is to disambiguate with WebEvent class in WebKit2. The modified files are all Objective-C++.
Comment 6 WebKit Commit Bot 2017-02-15 10:14:59 PST
Comment on attachment 301618 [details]
Proposed patch

Clearing flags on attachment: 301618

Committed r212376: <http://trac.webkit.org/changeset/212376>
Comment 7 WebKit Commit Bot 2017-02-15 10:15:05 PST
All reviewed patches have been landed.  Closing bug.