Otherwise, on my machine, resizing the terminal run-webkit-tests is running in makes it die.
Created attachment 301600 [details] Patch
Comment on attachment 301600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301600&action=review (Note: This is an informal review) Just a small nit, otherwise it looks fine. > Tools/Scripts/webkitpy/port/server_process.py:250 > + if e.args[0] in [errno.EINVAL, errno.EINTR]: I would use a tuple here, i.e: if e.args[0] in (errno.EINVAL, errno.EINTR):
>> Tools/Scripts/webkitpy/port/server_process.py:250 >> + if e.args[0] in [errno.EINVAL, errno.EINTR]: > > I would use a tuple here, i.e: > > if e.args[0] in (errno.EINVAL, errno.EINTR): I'm curious - why? I view a tuple mostly as structured heterogeneous collections of data where the order/length matter (e.g., a (name, age) tuple), and a list as a collection of heterogeneous collection (i.e. a list of error numbers, like here). If this is about tuples being immutable, that doesn't really matter much IMHO when used as literals like here. FWIW I'm happy to change it, but I'd like to understand why :-)
Comment on attachment 301600 [details] Patch [(I don't care if it's a tuple or a list. Ping again to ask for cq+ after sorting it out.)]
Comment on attachment 301600 [details] Patch Clearing flags on attachment: 301600 Committed r212631: <http://trac.webkit.org/changeset/212631>
All reviewed patches have been landed. Closing bug.