RESOLVED FIXED 168352
Web Inspector: CSS variable uses that are unresolved should have an error or warning icon 
https://bugs.webkit.org/show_bug.cgi?id=168352
Summary Web Inspector: CSS variable uses that are unresolved should have an error or ...
Blaze Burg
Reported 2017-02-14 20:02:25 PST
We don't show anything special when using var(--does-not-exist). We should strike out the variable or add an icon, and say what value is actually being used instead.
Attachments
Patch (4.69 KB, patch)
2017-02-27 16:13 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (78.71 KB, image/png)
2017-02-27 16:14 PST, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-14 20:03:11 PST
<rdar://problem/30527478>
Devin Rousso
Comment 2 2017-02-27 16:13:38 PST
Created attachment 302884 [details] Patch
Devin Rousso
Comment 3 2017-02-27 16:14:00 PST
Created attachment 302885 [details] [Image] After Patch is applied
Blaze Burg
Comment 4 2017-02-27 21:38:22 PST
Comment on attachment 302884 [details] Patch This is awesome. Will review in the morning.
Joseph Pecoraro
Comment 5 2017-02-28 12:12:08 PST
Yes, very neat! The only thing that is weird to me is "Click to delete and open autocomplete". Click to delete I get. The open autocomplete part seems weird.
Matt Baker
Comment 6 2017-02-28 12:27:31 PST
(In reply to comment #5) > Yes, very neat! > > The only thing that is weird to me is "Click to delete and open > autocomplete". Click to delete I get. The open autocomplete part seems weird. I had the same initial reaction. Note that we also do this for invalid property values: "The value “%s” is not supported for this property.\nClick to delete and open autocomplete."
Devin Rousso
Comment 7 2017-02-28 13:49:34 PST
(In reply to comment #6) > (In reply to comment #5) > > Yes, very neat! > > > > The only thing that is weird to me is "Click to delete and open > > autocomplete". Click to delete I get. The open autocomplete part seems weird. > > I had the same initial reaction. Note that we also do this for invalid > property values: > > "The value “%s” is not supported for this property.\nClick to delete and > open autocomplete." Exactly. I was thinking that in the case where the text was `margin: 10px var(--x) 5px;` the user wouldn't want the resulting text after click to be `margin: 10px 5px;`. I realize that this is what happens in actuality, but opening autocomplete suggests to the user that they replace the value with something valid instead of just getting rid of it.
WebKit Commit Bot
Comment 8 2017-02-28 15:35:48 PST
Comment on attachment 302884 [details] Patch Clearing flags on attachment: 302884 Committed r213187: <http://trac.webkit.org/changeset/213187>
WebKit Commit Bot
Comment 9 2017-02-28 15:35:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.