Bug 168350 – JSC: missing implementations of MacroAssemblerMIPS::load8SignedExtendTo32()

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Guillaume Emont]

Some implementations of MacroAssemblerMIPS::load8SignedExtendTo32() are missing, which prevents compilation on MIPS.

[Guillaume Emont]

Created attachment 301574 [details]
Patch

Proposed patch to add missing implementations.

[Guillaume Emont]

I'm in the process of sending a bunch of patches that make MIPS work again, more to come tomorrow.

[Csaba Osztrogonác]

Just a note, this function is needed 3 months ago - https://trac.webkit.org/changeset/208450. Wouldn't be better to have a MIPS buildbot to notice similar breakages in time?

[Guillaume Emont]

(In reply to comment #3)
> Just a note, this function is needed 3 months ago -
> https://trac.webkit.org/changeset/208450. Wouldn't be better to have a MIPS
> buildbot to notice similar breakages in time?

Absolutely! That's why we are working on that, but first we wanted to get things to a state where they build.

[Yusuke Suzuki]

Comment on attachment 301574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301574&action=review

r=me with a fix.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:764
> +    }

Looks good.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:796
> +        load8(address.m_ptr, dest);

Why is it OK? I think we should use load8SignedExtendTo32 here (and delegate to `void load8SignedExtendTo32(const void* address, RegisterID dest)`), correct?

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:806
> +        m_assembler.lb(dest, addrTempRegister, 0);

OK. The difference from load8 is using lb instead of lbu.

[Guillaume Emont]

Created attachment 301639 [details]
Patch

Corrected patch, thanks for the review!

[Yusuke Suzuki]

Comment on attachment 301639 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 301639 [details]
Patch

Clearing flags on attachment: 301639

Committed r212419: <http://trac.webkit.org/changeset/212419>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.