Bug 168345 - [CURL] ResourceError created with error information should have default type Type::General
Summary: [CURL] ResourceError created with error information should have default type ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Windows 10
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-14 16:43 PST by Basuke Suzuki
Modified: 2017-02-14 23:36 PST (History)
3 users (show)

See Also:

Attachments
fix (721 bytes, patch)
2017-02-14 16:51 PST, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2017-02-14 18:13 PST, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-02-14 16:43:07 PST 
CURL implementation of ResourceError has default value Type::General for type argument as like other implementations, but it is Type::None. This causes assertion error later.

Source/WebCore/platform/network/curl/ResourceError.h
ResourceError(const String& domain, int errorCode, const URL& failingURL, const String& localizedDescription, Type type = Type::Null)
Comment 1 Basuke Suzuki 2017-02-14 16:51:37 PST 
Created attachment 301564 [details]
fix
Comment 2 Basuke Suzuki 2017-02-14 18:13:03 PST 
Created attachment 301569 [details]
Patch
Comment 3 WebKit Commit Bot 2017-02-14 18:52:38 PST 
Comment on attachment 301569 [details]
Patch

Clearing flags on attachment: 301569

Committed r212340: <http://trac.webkit.org/changeset/212340>
Comment 4 WebKit Commit Bot 2017-02-14 18:52:41 PST 
All reviewed patches have been landed.  Closing bug.