Bug 168342 - List of WebCore symbols to re-export from WebKitLegacy should be built automatically
Summary: List of WebCore symbols to re-export from WebKitLegacy should be built automa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-14 15:45 PST by Alexey Proskuryakov
Modified: 2020-06-10 22:44 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch (8.67 KB, patch)
2017-02-14 15:58 PST, Alexey Proskuryakov
ap: commit-queue-
Details | Formatted Diff | Diff
proposed patch (8.69 KB, patch)
2017-02-15 17:00 PST, Alexey Proskuryakov
ap: commit-queue-
Details | Formatted Diff | Diff
proposed patch (8.69 KB, patch)
2017-02-15 17:33 PST, Alexey Proskuryakov
thorton: review+
ap: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-02-14 15:45:42 PST
We added a list of symbols to WebKit.iOS.exp, but this is not great. This list should be built automatically.
Comment 1 Alexey Proskuryakov 2017-02-14 15:57:43 PST
rdar://problem/26182266
Comment 2 Alexey Proskuryakov 2017-02-14 15:58:33 PST
Created attachment 301561 [details]
proposed patch

This is pretty much my first time ever making non-trivial changes to a makefile, please review carefully.
Comment 3 Alexey Proskuryakov 2017-02-15 17:00:35 PST
Created attachment 301674 [details]
proposed patch

Updated to use DEPLOYMENT_TARGET_CLANG_FLAG_NAME (cf. <rdar://problem/30502789>).
Comment 4 Alexey Proskuryakov 2017-02-15 17:33:12 PST
Created attachment 301679 [details]
proposed patch

Oh, and fixing the typo in bug title too.
Comment 5 Alexey Proskuryakov 2017-02-20 10:34:34 PST
Committed http://trac.webkit.org/r212659
Comment 6 David Kilzer (:ddkilzer) 2017-02-20 12:56:31 PST
Comment on attachment 301679 [details]
proposed patch

This looks fine.  I hope some day we can use XYZ_EXPORT macros to clean up some of the manual symbol lists.
Comment 7 Tim Horton 2020-06-10 22:36:17 PDT
Comment on attachment 301679 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301679&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:3297
> +				"$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/ReexportedWebCoreSymbols_$(CURRENT_ARCH).exp",

Seems like this got lost to history somehow
Comment 8 Tim Horton 2020-06-10 22:44:47 PDT
Probably https://trac.webkit.org/changeset/237047/webkit