RESOLVED WONTFIX 168334
Allow _WKFullscreenDelegates to specify a NSWindow to use for fullscreen. 
https://bugs.webkit.org/show_bug.cgi?id=168334
Summary Allow _WKFullscreenDelegates to specify a NSWindow to use for fullscreen.
Jer Noble
Reported 2017-02-14 14:16:33 PST
Allow _WKFullscreenDelegates to specify a NSWindow to use for fullscreen.
Attachments
Patch (12.22 KB, patch)
2017-02-14 14:19 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-02-14 14:19:17 PST
Created attachment 301546 [details] Patch
WebKit Commit Bot
Comment 2 2017-02-14 14:21:12 PST
Attachment 301546 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp:58: Declaration has space between type name and * in NSWindow *WebFullScreenManagerProxy [whitespace/declaration] [3] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 3 2017-02-15 00:20:04 PST
Nevermind; this turns out not to have been necessary.
Frédéric Wang (:fredw)
Comment 4 2018-02-28 07:51:37 PST
Comment on attachment 301546 [details] Patch Removing review request since this bug is WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.