Bug 168322 - [GStreamer] Implement MediaPlayerPrivate::hasSingleSecurityOrigin()
Summary: [GStreamer] Implement MediaPlayerPrivate::hasSingleSecurityOrigin()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-02-14 08:16 PST by Carlos Garcia Campos
Modified: 2017-02-15 00:50 PST (History)
1 user (show)

See Also:

Attachments
Patch (9.68 KB, patch)
2017-02-14 08:20 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (9.70 KB, patch)
2017-02-14 08:26 PST, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-14 08:16:12 PST 
It currently returns true unconditionally.
Comment 1 Carlos Garcia Campos 2017-02-14 08:20:39 PST 
Created attachment 301503 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-14 08:26:27 PST 
Created attachment 301504 [details]
Patch
Comment 3 Zan Dobersek 2017-02-14 23:28:20 PST 
Comment on attachment 301504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301504&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1440
> +    return resolvedOrigin->isSameSchemeHostPort(requestedOrigin.get());

Why isSameSchemeHostPort(), and not e.g. canAccess() or isSameOriginAs()? Is this specified anywhere, or is the Mac port doing this the same way?
Comment 4 Carlos Garcia Campos 2017-02-14 23:30:42 PST 
(In reply to comment #3)
> Comment on attachment 301504 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301504&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1440
> > +    return resolvedOrigin->isSameSchemeHostPort(requestedOrigin.get());
> 
> Why isSameSchemeHostPort(), and not e.g. canAccess() or isSameOriginAs()? Is
> this specified anywhere, or is the Mac port doing this the same way?

I just copied what other ports do.
Comment 5 Zan Dobersek 2017-02-14 23:38:20 PST 
Comment on attachment 301504 [details]
Patch

OK. Have Calvaris have a look at it, even if it's after the patch lands.
Comment 6 Carlos Garcia Campos 2017-02-14 23:44:57 PST 
(In reply to comment #5)
> Comment on attachment 301504 [details]
> Patch
> 
> OK. Have Calvaris have a look at it, even if it's after the patch lands.

Sure, thanks!
Comment 7 Carlos Garcia Campos 2017-02-14 23:46:37 PST 
Committed r212349: <http://trac.webkit.org/changeset/212349>