Bug 168304 - Use a set instead of a list for tests when parsing expectations
Summary: Use a set instead of a list for tests when parsing expectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 50635
  Show dependency tree / graph
 
Reported: 2017-02-14 04:49 PST by Florian Bruhin
Modified: 2017-02-14 13:03 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.70 KB, patch)
2017-02-14 04:55 PST, Florian Bruhin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Bruhin 2017-02-14 04:49:19 PST 
In _collect_matching_tests, a lot of membership tests are done on a giant list of strings. By making it a set instead, we can make those much faster, and there's no reason for it to be a list.
    
With ~45k tests and some 1000 expectations, this reduces the parse time from 34s to 3s on my machine.
Comment 1 Florian Bruhin 2017-02-14 04:55:27 PST 
Created attachment 301487 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-14 13:03:34 PST 
Comment on attachment 301487 [details]
Patch

Clearing flags on attachment: 301487

Committed r212319: <http://trac.webkit.org/changeset/212319>
Comment 3 WebKit Commit Bot 2017-02-14 13:03:38 PST 
All reviewed patches have been landed.  Closing bug.