Bug 168296 - [GTK] Make DragImageRef a RefPtr instead of a plain pointer
Summary: [GTK] Make DragImageRef a RefPtr instead of a plain pointer
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2017-02-14 01:22 PST by Carlos Garcia Campos
Modified: 2017-02-14 04:00 PST (History)
4 users (show)

See Also:

Patch (6.81 KB, patch)
2017-02-14 01:24 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (6.82 KB, patch)
2017-02-14 01:30 PST, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-14 01:22:52 PST
Maybe we can get rid of deleteDragImage() or even DragImageRef some day
Comment 1 Carlos Garcia Campos 2017-02-14 01:24:43 PST
Created attachment 301476 [details]
Comment 2 WebKit Commit Bot 2017-02-14 01:27:08 PST
Attachment 301476 [details] did not pass style-queue:

ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:64:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/gtk/DragImageGtk.cpp:64:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2017-02-14 01:30:52 PST
Created attachment 301477 [details]
Comment 4 Sergio Villar Senin 2017-02-14 03:23:39 PST
Comment on attachment 301477 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=301477&action=review

> Source/WebCore/ChangeLog:8
> +        Use RefPtr<cairo_surface_t> as DragImageRef for GTK+ port.

We should add some rationale here.
Comment 5 Carlos Garcia Campos 2017-02-14 04:00:03 PST
Committed r212287: <http://trac.webkit.org/changeset/212287>