Bug 168291 - [iOS] Form Validation Bubble should be sensitive to Dynamic Type
Summary: [iOS] Form Validation Bubble should be sensitive to Dynamic Type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://developer.apple.com/reference...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-13 23:44 PST by Jon Lee
Modified: 2017-02-15 10:14 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.96 KB, patch)
2017-02-15 09:05 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2017-02-13 23:44:40 PST 
When I change the text size through Settings > Display & Brightness, it should affect the size of the form text in the popover. Sort of the iOS version of 168271.
Comment 1 Radar WebKit Bug Importer 2017-02-13 23:45:15 PST 
<rdar://problem/30508593>
Comment 2 Chris Dumez 2017-02-14 06:54:51 PST 
Oh, is it different from the minimum font size setting? I will take a look.
Comment 3 Chris Dumez 2017-02-14 15:26:06 PST 
Note that WebKit does not seem to obey this iOS setting for fonts on Web pages.
Comment 5 Jon Lee 2017-02-14 16:03:12 PST 
(In reply to comment #3)
> Note that WebKit does not seem to obey this iOS setting for fonts on Web
> pages.

That is correct, but this is UI, not web content.

Use of -apple-system-* font-families will obey this setting.
Comment 6 Chris Dumez 2017-02-15 09:05:52 PST 
Created attachment 301624 [details]
Patch
Comment 7 Tim Horton 2017-02-15 09:44:48 PST 
Comment on attachment 301624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301624&action=review

> LayoutTests/platform/ios-simulator/TestExpectations:2844
> +# Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead.

Do we not have a way to test Dynamic Type adjustment?
Comment 8 Chris Dumez 2017-02-15 09:46:28 PST 
(In reply to comment #7)
> Comment on attachment 301624 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301624&action=review
> 
> > LayoutTests/platform/ios-simulator/TestExpectations:2844
> > +# Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead.
> 
> Do we not have a way to test Dynamic Type adjustment?

I could not find a programmatic way to do so.
Comment 9 WebKit Commit Bot 2017-02-15 10:14:05 PST 
Comment on attachment 301624 [details]
Patch

Clearing flags on attachment: 301624

Committed r212375: <http://trac.webkit.org/changeset/212375>
Comment 10 WebKit Commit Bot 2017-02-15 10:14:14 PST 
All reviewed patches have been landed.  Closing bug.