Bug 168289 - Web Inspector: RTL: table header columns and cells don't line up, dragging seems backwards
Summary: Web Inspector: RTL: table header columns and cells don't line up, dragging se...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-13 23:13 PST by BJ Burg
Modified: 2017-03-08 19:44 PST (History)
4 users (show)

See Also:


Attachments
VIDEO (RTL) (16.04 MB, video/quicktime)
2017-02-13 23:13 PST, BJ Burg
no flags Details
Patch (18.11 KB, patch)
2017-03-07 19:12 PST, Devin Rousso
bburg: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied (199.48 KB, image/png)
2017-03-07 19:12 PST, Devin Rousso
no flags Details
Patch (18.28 KB, patch)
2017-03-08 19:04 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-02-13 23:13:31 PST
Created attachment 301466 [details]
VIDEO (RTL)

This is really cool, alas, a bug.
Comment 1 Radar WebKit Bug Importer 2017-02-13 23:15:16 PST
<rdar://problem/30508257>
Comment 2 Devin Rousso 2017-03-07 19:12:42 PST
Created attachment 303758 [details]
Patch
Comment 3 Devin Rousso 2017-03-07 19:12:59 PST
Created attachment 303759 [details]
[Image] After Patch is applied
Comment 4 BJ Burg 2017-03-08 17:47:08 PST
Comment on attachment 303758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303758&action=review

r=me, nice work.

> Source/WebInspectorUI/ChangeLog:7
> +

Please summarize the change here. For example, you are changing column positioning algorithm to be bidirectional, when in RTL it uses right offsets.

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1836
> +        let percentRightColumn = (((endEdgeOfNextColumn - dragPoint) / this._dataTableElement.offsetWidth) * 100) + "%";

I think this code would be clearer with 'trailing' and 'leading' instead of start/end. For CSS we should stick to start/end to match CSS logical direction words.
Comment 5 Devin Rousso 2017-03-08 19:04:44 PST
Created attachment 303888 [details]
Patch
Comment 6 WebKit Commit Bot 2017-03-08 19:44:21 PST
Comment on attachment 303888 [details]
Patch

Clearing flags on attachment: 303888

Committed r213622: <http://trac.webkit.org/changeset/213622>
Comment 7 WebKit Commit Bot 2017-03-08 19:44:26 PST
All reviewed patches have been landed.  Closing bug.