RESOLVED FIXED 168289
Web Inspector: RTL: table header columns and cells don't line up, dragging seems backwards 
https://bugs.webkit.org/show_bug.cgi?id=168289
Summary Web Inspector: RTL: table header columns and cells don't line up, dragging se...
Blaze Burg
Reported 2017-02-13 23:13:31 PST
Created attachment 301466 [details] VIDEO (RTL) This is really cool, alas, a bug.
Attachments
VIDEO (RTL) (16.04 MB, video/quicktime)
2017-02-13 23:13 PST, Blaze Burg 		no flags
Details
Patch (18.11 KB, patch)
2017-03-07 19:12 PST, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
[Image] After Patch is applied (199.48 KB, image/png)
2017-03-07 19:12 PST, Devin Rousso 		no flags
Details
Patch (18.28 KB, patch)
2017-03-08 19:04 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-13 23:15:16 PST
<rdar://problem/30508257>
Devin Rousso
Comment 2 2017-03-07 19:12:42 PST
Created attachment 303758 [details] Patch
Devin Rousso
Comment 3 2017-03-07 19:12:59 PST
Created attachment 303759 [details] [Image] After Patch is applied
Blaze Burg
Comment 4 2017-03-08 17:47:08 PST
Comment on attachment 303758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303758&action=review r=me, nice work. > Source/WebInspectorUI/ChangeLog:7 > + Please summarize the change here. For example, you are changing column positioning algorithm to be bidirectional, when in RTL it uses right offsets. > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1836 > + let percentRightColumn = (((endEdgeOfNextColumn - dragPoint) / this._dataTableElement.offsetWidth) * 100) + "%"; I think this code would be clearer with 'trailing' and 'leading' instead of start/end. For CSS we should stick to start/end to match CSS logical direction words.
Devin Rousso
Comment 5 2017-03-08 19:04:44 PST
Created attachment 303888 [details] Patch
WebKit Commit Bot
Comment 6 2017-03-08 19:44:21 PST
Comment on attachment 303888 [details] Patch Clearing flags on attachment: 303888 Committed r213622: <http://trac.webkit.org/changeset/213622>
WebKit Commit Bot
Comment 7 2017-03-08 19:44:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.