Bug 168283 - Web Inspector: RTL: disclosure triangles in details section headers should be flipped and aligned right
Summary: Web Inspector: RTL: disclosure triangles in details section headers should be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-13 22:58 PST by BJ Burg
Modified: 2017-02-25 00:07 PST (History)
4 users (show)

See Also:

Attachments
SCREENSHOT (RTL) (172.68 KB, image/png)
2017-02-13 22:58 PST, BJ Burg 		no flags Details
Patch (6.09 KB, patch)
2017-02-23 10:52 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (8.62 KB, patch)
2017-02-23 15:36 PST, Devin Rousso 		bburg: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied (33.51 KB, image/png)
2017-02-23 15:50 PST, Devin Rousso 		no flags Details
Patch (8.18 KB, patch)
2017-02-24 23:32 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (28.22 KB, image/png)
2017-02-24 23:32 PST, Devin Rousso 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-02-13 22:58:49 PST 
Created attachment 301459 [details]
SCREENSHOT (RTL)

Probably don't need new art, just use a transform or something.
Comment 1 Radar WebKit Bug Importer 2017-02-13 22:59:12 PST 
<rdar://problem/30508067>
Comment 2 Devin Rousso 2017-02-23 10:52:19 PST 
Created attachment 302535 [details]
Patch
Comment 3 Devin Rousso 2017-02-23 10:53:08 PST 
Comment on attachment 302535 [details]
Patch

Whoops. Wrong bug :P
Comment 4 Devin Rousso 2017-02-23 15:36:05 PST 
Created attachment 302590 [details]
Patch
Comment 5 Devin Rousso 2017-02-23 15:50:15 PST 
Created attachment 302594 [details]
[Image] After Patch is applied
Comment 6 BJ Burg 2017-02-24 21:50:49 PST 
Comment on attachment 302590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302590&action=review

r=me

Your "after" screenshot should show the collapsed disclosure triangle as well as the expanded one.

> Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:32
> +

No need for extra newlines here.
Comment 7 Devin Rousso 2017-02-24 23:32:22 PST 
Created attachment 302740 [details]
Patch
Comment 8 Devin Rousso 2017-02-24 23:32:37 PST 
Created attachment 302741 [details]
[Image] After Patch is applied
Comment 9 WebKit Commit Bot 2017-02-25 00:07:10 PST 
Comment on attachment 302740 [details]
Patch

Clearing flags on attachment: 302740

Committed r212998: <http://trac.webkit.org/changeset/212998>
Comment 10 WebKit Commit Bot 2017-02-25 00:07:15 PST 
All reviewed patches have been landed.  Closing bug.