Bug 168277 - worker.postMessage should throw a TypeError if a SharedArrayBuffer is in the transfer list
Summary: worker.postMessage should throw a TypeError if a SharedArrayBuffer is in the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-13 21:39 PST by Filip Pizlo
Modified: 2017-02-14 09:10 PST (History)
4 users (show)

See Also:


Attachments
the patch (10.10 KB, patch)
2017-02-13 21:42 PST, Filip Pizlo
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-02-13 21:39:09 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2017-02-13 21:42:25 PST
Created attachment 301449 [details]
the patch
Comment 2 Mark Lam 2017-02-13 21:47:51 PST
Comment on attachment 301449 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301449&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        This is a simple spec compliance change. The title says it all.

Would be nice to add the url to the relevant spec (if you have it) for future reference.
Comment 3 Filip Pizlo 2017-02-14 09:07:34 PST
(In reply to comment #2)
> Comment on attachment 301449 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301449&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:10
> > +        This is a simple spec compliance change. The title says it all.
> 
> Would be nice to add the url to the relevant spec (if you have it) for
> future reference.

I wish I knew.  This is non-normative in the SharedArrayBuffer spec itself; in fact it doesn't mention a transfer list at all and refers to the fact that there is "general agreement" about how it should work.  Somewhere else there is a discussion that led to the current consensus, but I'm having a hard time finding it.  It was probably on github.
Comment 4 Filip Pizlo 2017-02-14 09:10:25 PST
Landed in https://trac.webkit.org/changeset/212301