Bug 168275 - Web Inspector: RTL: back/forward navigation buttons should not be flipped
Summary: Web Inspector: RTL: back/forward navigation buttons should not be flipped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks: 172741
  Show dependency tree / graph
 
Reported: 2017-02-13 21:25 PST by BJ Burg
Modified: 2017-05-30 19:14 PDT (History)
5 users (show)

See Also:

Attachments
SCREENSHOT (159.78 KB, image/png)
2017-02-13 21:25 PST, BJ Burg 		no flags Details
patch applied (LTR) (68.59 KB, image/png)
2017-02-19 14:47 PST, BJ Burg 		no flags Details
patch applied (RTL) (54.14 KB, image/png)
2017-02-19 14:47 PST, BJ Burg 		no flags Details
Patch (6.56 KB, patch)
2017-02-19 14:52 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch (8.30 KB, patch)
2017-02-20 17:34 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-02-13 21:25:55 PST 
Created attachment 301446 [details]
SCREENSHOT

It's customary for media controls and < > arrows to stay the same order in RTL layout. This is what Safari's back-forward buttons do.
Comment 1 Radar WebKit Bug Importer 2017-02-13 21:26:12 PST 
<rdar://problem/30506897>
Comment 2 BJ Burg 2017-02-14 00:01:12 PST 
So, the buttons will be laid out like [ < ] [ > ], but the meaning is reversed: < will go forward, > will got backward. We might be able to do a CSS transform to flip the icon.
Comment 3 BJ Burg 2017-02-19 14:47:15 PST 
Created attachment 302091 [details]
patch applied (LTR)
Comment 4 BJ Burg 2017-02-19 14:47:33 PST 
Created attachment 302092 [details]
patch applied (RTL)
Comment 5 BJ Burg 2017-02-19 14:52:29 PST 
Created attachment 302093 [details]
Patch
Comment 6 Matt Baker 2017-02-20 10:15:17 PST 
Comment on attachment 302093 [details]
Patch

Back/forward buttons in the Console tab filter are broken (no longer visible) in LTR mode. Also in RTL mode the Console tab is pretty broken. Since this is a small patch it seems reasonable to address that too.
Comment 7 BJ Burg 2017-02-20 17:29:54 PST 
(In reply to comment #6)
> Comment on attachment 302093 [details]
> Patch
> 
> Back/forward buttons in the Console tab filter are broken (no longer
> visible) in LTR mode. Also in RTL mode the Console tab is pretty broken.
> Since this is a small patch it seems reasonable to address that too.

I'll fix console navigation bar in a separate patch. Trying to keep these small to avoid rebase issues. I also write these mainly at night when I have small time increments.
Comment 8 BJ Burg 2017-02-20 17:34:01 PST 
Created attachment 302210 [details]
Patch
Comment 9 Matt Baker 2017-02-20 18:08:38 PST 
Comment on attachment 302210 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2017-02-20 18:34:23 PST 
Comment on attachment 302210 [details]
Patch

Clearing flags on attachment: 302210

Committed r212695: <http://trac.webkit.org/changeset/212695>
Comment 11 WebKit Commit Bot 2017-02-20 18:34:27 PST 
All reviewed patches have been landed.  Closing bug.