Following the discussion in https://github.com/KhronosGroup/WebGL/pull/2283
<rdar://problem/30504444>
Created attachment 301433 [details] Patch
Comment on attachment 301433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301433&action=review r=me > Source/WebCore/html/canvas/WebGLContextAttributes.idl:-39 > - GLboolean preferLowPowerToHighPerformance = false; So we're dropping support for this flag? What if there is content out there using preferLowPowerToHighPerformance = true? If we want, we could support both flags by not specifying a default value in the IDL and using std::optional<> on native side.
Comment on attachment 301433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301433&action=review >> Source/WebCore/html/canvas/WebGLContextAttributes.idl:-39 >> - GLboolean preferLowPowerToHighPerformance = false; > > So we're dropping support for this flag? What if there is content out there using preferLowPowerToHighPerformance = true? If we want, we could support both flags by not specifying a default value in the IDL and using std::optional<> on native side. Yeah. Normally I'd want to keep supporting it, but since no one has ever shipped a browser that implements it properly (*), I think it's ok to drop it. (*) We added it in the latest Safari/Sierra release, but then ignored the value by always choosing low power.
Committed r212316: <http://trac.webkit.org/changeset/212316>