Bug 168269 - Rename preferLowPowerToHighPerformance to powerPreference
Summary: Rename preferLowPowerToHighPerformance to powerPreference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-13 18:07 PST by Dean Jackson
Modified: 2017-02-14 12:15 PST (History)
8 users (show)

See Also:


Attachments
Patch (14.00 KB, patch)
2017-02-13 18:26 PST, Dean Jackson
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-02-13 18:07:08 PST
Following the discussion in https://github.com/KhronosGroup/WebGL/pull/2283
Comment 1 Radar WebKit Bug Importer 2017-02-13 18:08:29 PST
<rdar://problem/30504444>
Comment 2 Dean Jackson 2017-02-13 18:26:14 PST
Created attachment 301433 [details]
Patch
Comment 3 Chris Dumez 2017-02-13 18:43:28 PST
Comment on attachment 301433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301433&action=review

r=me

> Source/WebCore/html/canvas/WebGLContextAttributes.idl:-39
> -    GLboolean preferLowPowerToHighPerformance = false;

So we're dropping support for this flag? What if there is content out there using preferLowPowerToHighPerformance = true? If we want, we could support both flags by not specifying a default value in the IDL and using std::optional<> on native side.
Comment 4 Dean Jackson 2017-02-14 10:06:02 PST
Comment on attachment 301433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301433&action=review

>> Source/WebCore/html/canvas/WebGLContextAttributes.idl:-39
>> -    GLboolean preferLowPowerToHighPerformance = false;
> 
> So we're dropping support for this flag? What if there is content out there using preferLowPowerToHighPerformance = true? If we want, we could support both flags by not specifying a default value in the IDL and using std::optional<> on native side.

Yeah. Normally I'd want to keep supporting it, but since no one has ever shipped a browser that implements it properly (*), I think it's ok to drop it.

(*) We added it in the latest Safari/Sierra release, but then ignored the value by always choosing low power.
Comment 5 Dean Jackson 2017-02-14 12:15:35 PST
Committed r212316: <http://trac.webkit.org/changeset/212316>